From: Josh Hunt <johunt@akamai.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Baron, Jason" <jbaron@akamai.com>
Subject: Re: [PATCH] panic: add TAINT_SOFTLOCKUP
Date: Mon, 23 Jun 2014 17:45:00 -0500 [thread overview]
Message-ID: <53A8ADEC.6070406@akamai.com> (raw)
In-Reply-To: <20140623151121.44f17779004e94ab620b837c@linux-foundation.org>
On 06/23/2014 05:11 PM, Andrew Morton wrote:
> On Tue, 3 Jun 2014 22:12:35 -0400 Josh Hunt <johunt@akamai.com> wrote:
>
>> This taint flag will be set if the system has ever entered a softlockup
>> state. Similar to TAINT_WARN it is useful to know whether or not the system
>> has been in a softlockup state when debugging.
>>
>> ...
>>
>> @@ -329,6 +329,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
>>
>> if (softlockup_panic)
>> panic("softlockup: hung tasks");
>> + add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
>> __this_cpu_write(soft_watchdog_warn, true);
>> } else
>> __this_cpu_write(soft_watchdog_warn, false);
>
> Would make more sense to have applied the taint *before* calling
> panic()?
Andrew
Yep, that's a good call. Thanks. Do you want me to send a v2 or did you
take care of it?
In addition to adding the softlockup taint flag, do you think it'd be
reasonable to add another flag for page allocation failures? I think
it'd be nice to be able to account for these conditions somehow without
having to parse dmesg, etc. As with the softlockup flag, it's helpful to
know if your system had encountered a page allocation failure at some
point before the crash or whatever you're debugging.
Thanks
Josh
next prev parent reply other threads:[~2014-06-23 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 2:12 [PATCH] panic: add TAINT_SOFTLOCKUP Josh Hunt
2014-06-23 22:11 ` Andrew Morton
2014-06-23 22:45 ` Josh Hunt [this message]
2014-06-23 22:51 ` Andrew Morton
2014-06-24 14:22 ` Josh Hunt
2014-06-24 15:06 ` Dave Jones
2014-06-24 15:20 ` Dave Jones
2014-06-25 0:45 ` David Rientjes
[not found] ` <CAPDOMVifbWCohymLyCc6cxG7t9WCDLTbCWRZx8xyG3DOMFqKqg@mail.gmail.com>
2014-06-25 2:21 ` Nick Krause
2014-06-25 3:24 ` Josh Hunt
2014-06-25 3:39 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A8ADEC.6070406@akamai.com \
--to=johunt@akamai.com \
--cc=akpm@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.