From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] KVM: PPC: Book3E: Unlock mmu_lock when setting caching atttribute Date: Tue, 24 Jun 2014 15:39:45 +0200 Message-ID: <53A97FA1.4040503@suse.de> References: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bharat Bhushan To: Mihai Caraman , kvm-ppc@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:44583 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbaFXNjs (ORCPT ); Tue, 24 Jun 2014 09:39:48 -0400 In-Reply-To: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> Sender: kvm-owner@vger.kernel.org List-ID: On 18.06.14 17:45, Mihai Caraman wrote: > The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f > kvm: powerpc: use caching attributes as per linux pte > do not handle properly the error case, letting mmu_lock locked. The lock > will further generate a RCU stall from kvmppc_e500_emul_tlbwe() caller. > > In case of an error go to out label. > > Signed-off-by: Mihai Caraman > Cc: Bharat Bhushan Thanks, applied to for-3.16. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CAC391A0010 for ; Tue, 24 Jun 2014 23:39:50 +1000 (EST) Message-ID: <53A97FA1.4040503@suse.de> Date: Tue, 24 Jun 2014 15:39:45 +0200 From: Alexander Graf MIME-Version: 1.0 To: Mihai Caraman , kvm-ppc@vger.kernel.org Subject: Re: [PATCH] KVM: PPC: Book3E: Unlock mmu_lock when setting caching atttribute References: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Bharat Bhushan , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 18.06.14 17:45, Mihai Caraman wrote: > The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f > kvm: powerpc: use caching attributes as per linux pte > do not handle properly the error case, letting mmu_lock locked. The lock > will further generate a RCU stall from kvmppc_e500_emul_tlbwe() caller. > > In case of an error go to out label. > > Signed-off-by: Mihai Caraman > Cc: Bharat Bhushan Thanks, applied to for-3.16. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 24 Jun 2014 13:39:45 +0000 Subject: Re: [PATCH] KVM: PPC: Book3E: Unlock mmu_lock when setting caching atttribute Message-Id: <53A97FA1.4040503@suse.de> List-Id: References: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1403106305-11565-1-git-send-email-mihai.caraman@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mihai Caraman , kvm-ppc@vger.kernel.org Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bharat Bhushan On 18.06.14 17:45, Mihai Caraman wrote: > The patch 08c9a188d0d0fc0f0c5e17d89a06bb59c493110f > kvm: powerpc: use caching attributes as per linux pte > do not handle properly the error case, letting mmu_lock locked. The lock > will further generate a RCU stall from kvmppc_e500_emul_tlbwe() caller. > > In case of an error go to out label. > > Signed-off-by: Mihai Caraman > Cc: Bharat Bhushan Thanks, applied to for-3.16. Alex