Re: [PATCH 1/3] drm/radeon: stop poisoning the GART TLB

From: "Michel Dänzer" <michel@daenzer.net>
To: "Christian König" <christian.koenig@amd.com>,
	"Alex Deucher" <alexdeucher@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/radeon: stop poisoning the GART TLB
Date: Wed, 25 Jun 2014 12:59:15 +0900	[thread overview]
Message-ID: <53AA4913.10401@daenzer.net> (raw)
In-Reply-To: <53A94F94.6040603@amd.com>

On 24.06.2014 19:14, Christian König wrote:
> Am 24.06.2014 08:49, schrieb Michel Dänzer:
>> On 23.06.2014 18:56, Christian König wrote:
>>> Am 23.06.2014 10:15, schrieb Michel Dänzer:
>>>> On 19.06.2014 18:45, Christian König wrote:
>>>>
>>>>> I think even when we revert to the old code we have a couple of
>>>>> unsolved
>>>>> problems with the VM support or in the driver in general where we
>>>>> should
>>>>> try to understand the underlying reason for it instead of applying
>>>>> more
>>>>> workarounds.
>>>> I'm not suggesting applying more workarounds but going back to a known
>>>> more stable state. It seems like we've maneuvered ourselves to a rather
>>>> uncomfortable position from there, with no clear way to a better place.
>>>> But if we basically started from the 3.14 state again, we have a few
>>>> known hurdles like mine and Marek's Bonaire etc. which we know any
>>>> further improvements will have to pass before they can be considered
>>>> for
>>>> general consumption.
>>> Yeah agree, especially on the uncomfortable position.
>>>
>>> Please try with the two attached patches applied on top of 3.15 and
>>> retest. They should revert back to the old implementation.
>> Unfortunately, X fails to start with these, see the attached excerpt
>> from dmesg.
> 
> My fault, incorrectly solved a merge conflict and then failed to test
> the right kernel.
> 
> BTW: Wasn't there an option to tell grup to use the latest installed
> kernel instead of the one with the highest version number? Can't seem to
> find that any more.

No idea, unfortunately.

> Please try attached patches instead,

With these patches, 3.15 just survived two piglit runs on my Bonaire,
one with the GART poisoning fix and one without. It never survived a
single run before.

Acked-and-Tested-by: Michel Dänzer <michel.daenzer@amd.com>

-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer