From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzgbz-00033D-2A for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:23:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wzgbp-0003lN-TU for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:23:14 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:56786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzgbp-0003lF-Ne for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:23:05 -0400 Received: by mail-we0-f176.google.com with SMTP id u56so1483767wes.35 for ; Tue, 24 Jun 2014 23:23:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53AA6AC2.1060301@redhat.com> Date: Wed, 25 Jun 2014 08:22:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-3-git-send-email-tiejun.chen@intel.com> In-Reply-To: <1403662641-28526-3-git-send-email-tiejun.chen@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com Il 25/06/2014 04:17, Tiejun Chen ha scritto: > +static int create_pseudo_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > +{ > + struct PCIDevice *dev; > + > + char rid; > + > + /* We havt to use a simple PCI device to fake this ISA bridge > + * to avoid making some confusion to BIOS and ACPI. > + */ > + dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "pseudo-intel-pch-isa-bridge"); > + > + qdev_init_nofail(&dev->qdev); > + > + pci_config_set_vendor_id(dev->config, hdev->vendor_id); > + pci_config_set_device_id(dev->config, hdev->device_id); > + > + xen_host_pci_get_block(hdev, PCI_REVISION_ID, (uint8_t *)&rid, 1); > + > + pci_config_set_revision(dev->config, rid); > + > + XEN_PT_LOG(dev, "The pseudo Intel PCH ISA bridge created.\n"); > + return 0; > +} This patch doesn't compile on its own (this static function is unused). pci_create_pch should be moved in this patch. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge Date: Wed, 25 Jun 2014 08:22:58 +0200 Message-ID: <53AA6AC2.1060301@redhat.com> References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-3-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403662641-28526-3-git-send-email-tiejun.chen@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Tiejun Chen , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org Il 25/06/2014 04:17, Tiejun Chen ha scritto: > +static int create_pseudo_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev) > +{ > + struct PCIDevice *dev; > + > + char rid; > + > + /* We havt to use a simple PCI device to fake this ISA bridge > + * to avoid making some confusion to BIOS and ACPI. > + */ > + dev = pci_create(bus, PCI_DEVFN(0x1f, 0), "pseudo-intel-pch-isa-bridge"); > + > + qdev_init_nofail(&dev->qdev); > + > + pci_config_set_vendor_id(dev->config, hdev->vendor_id); > + pci_config_set_device_id(dev->config, hdev->device_id); > + > + xen_host_pci_get_block(hdev, PCI_REVISION_ID, (uint8_t *)&rid, 1); > + > + pci_config_set_revision(dev->config, rid); > + > + XEN_PT_LOG(dev, "The pseudo Intel PCH ISA bridge created.\n"); > + return 0; > +} This patch doesn't compile on its own (this static function is unused). pci_create_pch should be moved in this patch. Paolo