From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzgdk-00042N-CS for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:25:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wzgdb-0004cZ-8W for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:25:04 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:57834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzgdb-0004cP-1X for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:24:55 -0400 Received: by mail-wi0-f173.google.com with SMTP id cc10so7118208wib.6 for ; Tue, 24 Jun 2014 23:24:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53AA6B2D.2030804@redhat.com> Date: Wed, 25 Jun 2014 08:24:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> In-Reply-To: <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com Il 25/06/2014 04:17, Tiejun Chen ha scritto: > + if (xen_enabled() && xen_has_gfx_passthru) { > + d = pci_create_simple(b, 0, TYPE_I440FX_XEN_PCI_DEVICE); > + *pi440fx_state = I440FX_XEN_PCI_DEVICE(d); > + pci_create_pch(b); > + } else { > + d = pci_create_simple(b, 0, TYPE_I440FX_PCI_DEVICE); > + *pi440fx_state = I440FX_PCI_DEVICE(d); > + } As mentioned in the review of v4, this should be a separate, Xen-specific machine. pci_create_pch should not be called in generic PC code. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough Date: Wed, 25 Jun 2014 08:24:45 +0200 Message-ID: <53AA6B2D.2030804@redhat.com> References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Tiejun Chen , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org Il 25/06/2014 04:17, Tiejun Chen ha scritto: > + if (xen_enabled() && xen_has_gfx_passthru) { > + d = pci_create_simple(b, 0, TYPE_I440FX_XEN_PCI_DEVICE); > + *pi440fx_state = I440FX_XEN_PCI_DEVICE(d); > + pci_create_pch(b); > + } else { > + d = pci_create_simple(b, 0, TYPE_I440FX_PCI_DEVICE); > + *pi440fx_state = I440FX_PCI_DEVICE(d); > + } As mentioned in the review of v4, this should be a separate, Xen-specific machine. pci_create_pch should not be called in generic PC code. Paolo