From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754864AbaFYHEz (ORCPT ); Wed, 25 Jun 2014 03:04:55 -0400 Received: from nasmtp01.atmel.com ([192.199.1.245]:19502 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754596AbaFYHEy (ORCPT ); Wed, 25 Jun 2014 03:04:54 -0400 X-Greylist: delayed 308 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Jun 2014 03:04:54 EDT Message-ID: <53AA735C.7050805@atmel.com> Date: Wed, 25 Jun 2014 14:59:40 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Boris BREZILLON CC: Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , , Subject: Re: [PATCH 1/2] ARM: at91/dt: describe rgmii ethernet phy connected to sama5d3xek boards References: <1403649878-28242-1-git-send-email-boris.brezillon@free-electrons.com> <1403649878-28242-2-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1403649878-28242-2-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 06/25/2014 06:44 AM, Boris BREZILLON wrote: > Add ethernet-phy node to specify phy address (on the MDIO bus) and phy > interrupt (connected to pin PB25). > > Define board specific delays to apply to RGMII signals. > > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/sama5d3xcm.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi > index b0b1331..2185ad8 100644 > --- a/arch/arm/boot/dts/sama5d3xcm.dtsi > +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi > @@ -34,6 +34,22 @@ > > macb0: ethernet@f0028000 { > phy-mode = "rgmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@1 { The GMAC PHY address is 0x7 while not 0x1. > + interrupt-parent = <&pioB>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + reg = <1>; Nitpick: as usual, we will add "0x" prefix in reg property. > + txen-skew-ps = <800>; > + txc-skew-ps = <12000>; > + rxdv-skew-ps = <400>; > + rxc-skew-ps = <12000>; > + rxd0-skew-ps = <400>; > + rxd1-skew-ps = <400>; > + rxd2-skew-ps = <400>; > + rxd3-skew-ps = <400>; > + }; > }; > > pmc: pmc@fffffc00 { > Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: voice.shen@atmel.com (Bo Shen) Date: Wed, 25 Jun 2014 14:59:40 +0800 Subject: [PATCH 1/2] ARM: at91/dt: describe rgmii ethernet phy connected to sama5d3xek boards In-Reply-To: <1403649878-28242-2-git-send-email-boris.brezillon@free-electrons.com> References: <1403649878-28242-1-git-send-email-boris.brezillon@free-electrons.com> <1403649878-28242-2-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <53AA735C.7050805@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris, On 06/25/2014 06:44 AM, Boris BREZILLON wrote: > Add ethernet-phy node to specify phy address (on the MDIO bus) and phy > interrupt (connected to pin PB25). > > Define board specific delays to apply to RGMII signals. > > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/sama5d3xcm.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi > index b0b1331..2185ad8 100644 > --- a/arch/arm/boot/dts/sama5d3xcm.dtsi > +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi > @@ -34,6 +34,22 @@ > > macb0: ethernet at f0028000 { > phy-mode = "rgmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy at 1 { The GMAC PHY address is 0x7 while not 0x1. > + interrupt-parent = <&pioB>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + reg = <1>; Nitpick: as usual, we will add "0x" prefix in reg property. > + txen-skew-ps = <800>; > + txc-skew-ps = <12000>; > + rxdv-skew-ps = <400>; > + rxc-skew-ps = <12000>; > + rxd0-skew-ps = <400>; > + rxd1-skew-ps = <400>; > + rxd2-skew-ps = <400>; > + rxd3-skew-ps = <400>; > + }; > }; > > pmc: pmc at fffffc00 { > Best Regards, Bo Shen