From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzhFB-0008I5-PQ for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzhF2-0001tg-0m for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:03:45 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:42074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzhF1-0001tN-Ql for qemu-devel@nongnu.org; Wed, 25 Jun 2014 03:03:35 -0400 Received: by mail-wi0-f169.google.com with SMTP id hi2so6987374wib.2 for ; Wed, 25 Jun 2014 00:03:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53AA743E.9000602@redhat.com> Date: Wed, 25 Jun 2014 09:03:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com> <1403073840-32603-35-git-send-email-pbonzini@redhat.com> <53AA66D2.8090307@weilnetz.de> In-Reply-To: <53AA66D2.8090307@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2.1 34/36] qemu-char: make writes thread-safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org Cc: wenchaoqemu@gmail.com, lcapitulino@redhat.com Il 25/06/2014 08:06, Stefan Weil ha scritto: > Am 18.06.2014 08:43, schrieb Paolo Bonzini: >> This will let threads other than the I/O thread raise QMP events. >> >> GIOChannel is thread-safe, and send and receive state is usually >> well-separated. The only driver that requires some care is the >> pty driver, where some of the state is shared by the read and write >> sides. That state is protected with the chr_write_lock too. >> >> Reviewed-by: Fam Zheng >> Signed-off-by: Paolo Bonzini >> --- >> include/sysemu/char.h | 11 ++++++---- >> qemu-char.c | 58 ++++++++++++++++++++++++++++++++++++++++----------- >> 2 files changed, 53 insertions(+), 16 deletions(-) >> > > Latest QEMU is broken for w64. This command no longer starts the GTK gui: > > wine64 x86_64-softmmu/qemu-system-x86_64 -L pc-bios > > Wine reports a dead lock: > > err:ntdll:RtlpWaitForCriticalSection section 0x964f0 "?" wait timed out > in thread 0009, blocked by 0000, retrying (60 sec) Actually this message is more likely to be a missing qemu_mutex_init, and in fact that's what it is. I'm sorry, I'll send a patch right away. Paolo