From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 25 Jun 2014 11:00:01 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:51556 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6859928AbaFYI76h3F7x (ORCPT ); Wed, 25 Jun 2014 10:59:58 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 86EF1E3330C75; Wed, 25 Jun 2014 09:59:49 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Wed, 25 Jun 2014 09:59:51 +0100 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 25 Jun 2014 09:59:51 +0100 Message-ID: <53AA8F87.6000701@imgtec.com> Date: Wed, 25 Jun 2014 09:59:51 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Deng-Cheng Zhu , CC: , , , , Subject: Re: [PATCH v3 2/9] MIPS: KVM: Use KVM internal logger References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> <1403631071-6012-3-git-send-email-dengcheng.zhu@imgtec.com> In-Reply-To: <1403631071-6012-3-git-send-email-dengcheng.zhu@imgtec.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40795 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Deng-Cheng, On 24/06/14 18:31, Deng-Cheng Zhu wrote: > @@ -2213,8 +2209,8 @@ enum emulation_result kvm_mips_check_privilege(unsigned long cause, > * address error exception to the guest > */ > if (badvaddr >= (unsigned long) KVM_GUEST_KSEG0) { > - printk("%s: LD MISS @ %#lx\n", __func__, > - badvaddr); > + kvm_err("%s: LD MISS @ %#lx\n", __func__, > + badvaddr); This should probably be kvm_debug since it isn't fatal to the whole VM (the exception gets passed on to the guest kernel to handle), otherwise guest userland could maliciously spam the host log by repeatedly trying to access beyond the T&E useg. Same goes for the other printks in this function It probably was only useful to sanity check that userland wasn't trying to access memory that would be accessible on a normal MIPS core but isn't with the T&E segment layout. Otherwise this patch looks okay to me. Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:51556 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6859928AbaFYI76h3F7x (ORCPT ); Wed, 25 Jun 2014 10:59:58 +0200 Message-ID: <53AA8F87.6000701@imgtec.com> Date: Wed, 25 Jun 2014 09:59:51 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH v3 2/9] MIPS: KVM: Use KVM internal logger References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> <1403631071-6012-3-git-send-email-dengcheng.zhu@imgtec.com> In-Reply-To: <1403631071-6012-3-git-send-email-dengcheng.zhu@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Deng-Cheng Zhu , pbonzini@redhat.com Cc: gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com, ralf@linux-mips.org, linux-mips@linux-mips.org Message-ID: <20140625085951.WysE7lvYk-rFicq3Mk1Fp11MX5Bnc97aXuHmwLpIWW4@z> Hi Deng-Cheng, On 24/06/14 18:31, Deng-Cheng Zhu wrote: > @@ -2213,8 +2209,8 @@ enum emulation_result kvm_mips_check_privilege(unsigned long cause, > * address error exception to the guest > */ > if (badvaddr >= (unsigned long) KVM_GUEST_KSEG0) { > - printk("%s: LD MISS @ %#lx\n", __func__, > - badvaddr); > + kvm_err("%s: LD MISS @ %#lx\n", __func__, > + badvaddr); This should probably be kvm_debug since it isn't fatal to the whole VM (the exception gets passed on to the guest kernel to handle), otherwise guest userland could maliciously spam the host log by repeatedly trying to access beyond the T&E useg. Same goes for the other printks in this function It probably was only useful to sanity check that userland wasn't trying to access memory that would be accessible on a normal MIPS core but isn't with the T&E segment layout. Otherwise this patch looks okay to me. Cheers James