From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp2-g21.free.fr ([212.27.42.2]:51450 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbaFYJot (ORCPT ); Wed, 25 Jun 2014 05:44:49 -0400 Message-ID: <53AA9A0F.605@eukrea.com> Date: Wed, 25 Jun 2014 11:44:47 +0200 From: Denis Carikli MIME-Version: 1.0 To: Sascha Hauer CC: devel@driverdev.osuosl.org, Russell King , =?ISO-8859-1?Q?Eric_B=E9nard?= , David Airlie , Greg Kroah-Hartman , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Sascha Hauer , Philipp Zabel , Shawn Guo , linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab Subject: Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings References: <1402913484-25910-1-git-send-email-denis@eukrea.com> <1402913484-25910-4-git-send-email-denis@eukrea.com> <20140625044845.GK5918@pengutronix.de> In-Reply-To: <20140625044845.GK5918@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 06/25/2014 06:48 AM, Sascha Hauer wrote: >> +#define ENABLE_POL_LOW 0 >> +#define ENABLE_POL_HIGH 1 > > Adding defines without a proper namespace (IPU_) outside a driver > private header file is not nice. Anyway, instead of adding the > defines ... Fixed in "imx-drm: use defines for clock polarity settings" and in "imx-drm: Use drm_display_mode timings flags.". Denis. From mboxrd@z Thu Jan 1 00:00:00 1970 From: denis@eukrea.com (Denis Carikli) Date: Wed, 25 Jun 2014 11:44:47 +0200 Subject: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings In-Reply-To: <20140625044845.GK5918@pengutronix.de> References: <1402913484-25910-1-git-send-email-denis@eukrea.com> <1402913484-25910-4-git-send-email-denis@eukrea.com> <20140625044845.GK5918@pengutronix.de> Message-ID: <53AA9A0F.605@eukrea.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/25/2014 06:48 AM, Sascha Hauer wrote: >> +#define ENABLE_POL_LOW 0 >> +#define ENABLE_POL_HIGH 1 > > Adding defines without a proper namespace (IPU_) outside a driver > private header file is not nice. Anyway, instead of adding the > defines ... Fixed in "imx-drm: use defines for clock polarity settings" and in "imx-drm: Use drm_display_mode timings flags.". Denis. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Carikli Subject: Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings Date: Wed, 25 Jun 2014 11:44:47 +0200 Message-ID: <53AA9A0F.605@eukrea.com> References: <1402913484-25910-1-git-send-email-denis@eukrea.com> <1402913484-25910-4-git-send-email-denis@eukrea.com> <20140625044845.GK5918@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140625044845.GK5918@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Sascha Hauer Cc: devel@driverdev.osuosl.org, Russell King , Sascha Hauer , David Airlie , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Laurent Pinchart , =?ISO-8859-1?Q?Eric_B=E9nard?= , Philipp Zabel , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 06/25/2014 06:48 AM, Sascha Hauer wrote: >> +#define ENABLE_POL_LOW 0 >> +#define ENABLE_POL_HIGH 1 > > Adding defines without a proper namespace (IPU_) outside a driver > private header file is not nice. Anyway, instead of adding the > defines ... Fixed in "imx-drm: use defines for clock polarity settings" and in "imx-drm: Use drm_display_mode timings flags.". Denis.