From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WzkP4-0001tN-Ia
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 06:26:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WzkOx-0008FT-2e
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 06:26:10 -0400
Message-ID: <53AAA3BC.4010500@weilnetz.de>
Date: Wed, 25 Jun 2014 12:26:04 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1403679897-11480-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1403679897-11480-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 2.1] qemu-char: initialize out_lock
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org

Am 25.06.2014 09:04, schrieb Paolo Bonzini:
> Otherwise, Windows fails with a deadlock.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-char.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 2e50a10..17bd360 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -94,6 +94,7 @@ static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs =
>  CharDriverState *qemu_chr_alloc(void)
>  {
>      CharDriverState *chr = g_malloc0(sizeof(CharDriverState));
> +    qemu_mutex_init(&chr->chr_write_lock);
>      return chr;
>  }
>  


Thanks, this fixes the problem with QEMU for Windows.

Tested-by: Stefan Weil <sw@weilnetz.de>