From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzlbq-00068S-Gi for qemu-devel@nongnu.org; Wed, 25 Jun 2014 07:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wzlbk-0002i8-Cq for qemu-devel@nongnu.org; Wed, 25 Jun 2014 07:43:26 -0400 Message-ID: <53AAB5D6.1030608@suse.de> Date: Wed, 25 Jun 2014 13:43:18 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1401442460-32648-1-git-send-email-aik@ozlabs.ru> <1401442460-32648-9-git-send-email-aik@ozlabs.ru> <538DCB4C.4040905@ozlabs.ru> <5393A77C.80202@ozlabs.ru> <5399C112.2090205@ozlabs.ru> <5399DBDD.3050101@suse.de> <874mz98bd2.fsf@troll.troll> In-Reply-To: <874mz98bd2.fsf@troll.troll> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 8/9] vmstate: Add preallocation for migrating arrays (VMS_ALLOC flag) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: Alexey Kardashevskiy , Peter Maydell , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 25.06.14 13:41, Juan Quintela wrote: > Alexander Graf wrote: >> On 06/12/2014 05:02 PM, Alexey Kardashevskiy wrote: >>> On 06/08/2014 09:59 AM, Alexey Kardashevskiy wrote: >>>> On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote: >>>>> On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote: >>>>>> There are few helpers already to support array migration. However they all >>>>>> require the destination side to preallocate arrays before migration which >>>>>> is not always possible due to unknown array size as it might be some >>>>>> sort of dynamic state. One of the examples is an array of MSIX-enabled >>>>>> devices in SPAPR PHB - this array may vary from 0 to 65536 entries and >>>>>> its size depends on guest's ability to enable MSIX or do PCI hotplug. >>>>>> >>>>>> This adds new VMSTATE_VARRAY_STRUCT_ALLOC macro which is pretty similar to >>>>>> VMSTATE_STRUCT_VARRAY_POINTER_INT32 but it can alloc memory for migratign >>>>>> array on the destination side. >>>>>> >>>>>> This defines VMS_ALLOC flag for a field. >>>>>> >>>>>> This changes vmstate_base_addr() to do the allocation when receiving >>>>>> migration. >>>>> >>>>> Juan, Peter? No hurry, just pinging in order not to forget :) Thanks! >>>> Hi, anyone? :) >>> Ping? >> Acked-by: Alexander Graf > Reviewed-by: Juan Quintela > > BTW, should I include it, or will it got include through this series? Thanks a lot for the review :). I'll pick it up - the next patch depends on it and we're getting very close to hard freeze. Alex