From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzmHM-0003x8-J9 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 08:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzmHF-0001Gs-1g for qemu-devel@nongnu.org; Wed, 25 Jun 2014 08:26:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzmHE-0001Gj-Pf for qemu-devel@nongnu.org; Wed, 25 Jun 2014 08:26:12 -0400 Message-ID: <53AABC81.2090206@redhat.com> Date: Wed, 25 Jun 2014 14:11:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <53AA8ACF.3070101@redhat.com> <20140625084835.GF32652@redhat.com> <53AA8E7D.809@intel.com> <20140625090925.GH32652@redhat.com> <53AA9480.1010005@intel.com> <53AA96DF.6070501@redhat.com> <53AA9B58.6050803@intel.com> <20140625095533.GE6357@redhat.com> <53AA9D79.3080003@redhat.com> <53AA9F3A.5030004@intel.com> <20140625102119.GJ6357@redhat.com> In-Reply-To: <20140625102119.GJ6357@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , "Chen, Tiejun" Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, Kelly.Zytaruk@amd.com, anthony.perard@citrix.com, anthony@codemonkey.ws, yang.z.zhang@intel.com Il 25/06/2014 12:21, Michael S. Tsirkin ha scritto: > So what if you dont? > > if (!pch) > DRM_DEBUG_KMS("No PCH found.\n"); > > Is that all? Seems harmless enough. > The switch statement above sets dev_priv->pch_type. If it is set wrong, everything goes wrong. grep for HAS_PCH_. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v5][PATCH 0/5] xen: add Intel IGD passthrough support Date: Wed, 25 Jun 2014 14:11:45 +0200 Message-ID: <53AABC81.2090206@redhat.com> References: <53AA8ACF.3070101@redhat.com> <20140625084835.GF32652@redhat.com> <53AA8E7D.809@intel.com> <20140625090925.GH32652@redhat.com> <53AA9480.1010005@intel.com> <53AA96DF.6070501@redhat.com> <53AA9B58.6050803@intel.com> <20140625095533.GE6357@redhat.com> <53AA9D79.3080003@redhat.com> <53AA9F3A.5030004@intel.com> <20140625102119.GJ6357@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140625102119.GJ6357@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: "Michael S. Tsirkin" , "Chen, Tiejun" Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, Kelly.Zytaruk@amd.com, anthony.perard@citrix.com, anthony@codemonkey.ws, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org Il 25/06/2014 12:21, Michael S. Tsirkin ha scritto: > So what if you dont? > > if (!pch) > DRM_DEBUG_KMS("No PCH found.\n"); > > Is that all? Seems harmless enough. > The switch statement above sets dev_priv->pch_type. If it is set wrong, everything goes wrong. grep for HAS_PCH_. Paolo