From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH ARM v5 17/20] mini-os: headers for ARM
Date: Thu, 26 Jun 2014 17:26:04 +0100
Message-ID: <53AC499C.6090004@linaro.org>
References: <1403782117-15125-1-git-send-email-talex5@gmail.com>
	<1403782117-15125-18-git-send-email-talex5@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1X0CV5-0001jj-Qf
	for xen-devel@lists.xenproject.org; Thu, 26 Jun 2014 16:26:15 +0000
Received: by mail-wg0-f46.google.com with SMTP id y10so3949622wgg.17
	for <xen-devel@lists.xenproject.org>;
	Thu, 26 Jun 2014 09:26:11 -0700 (PDT)
In-Reply-To: <1403782117-15125-18-git-send-email-talex5@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>, xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com, Dave.Scott@eu.citrix.com, anil@recoil.org
List-Id: xen-devel@lists.xenproject.org

Hi Thomas,

On 06/26/2014 12:28 PM, Thomas Leonard wrote:
> diff --git a/extras/mini-os/include/arm/hypercall-arm.h b/extras/mini-os/include/arm/hypercall-arm.h
> new file mode 100644
> index 0000000..6d862ff
> --- /dev/null
> +++ b/extras/mini-os/include/arm/hypercall-arm.h
> +#ifndef __HYPERCALL_ARM_H__
> +#define __HYPERCALL_ARM_H__
> +
> +#include <xen/xen.h>
> +#include <xen/sched.h>
> +#include <xen/xsm/flask_op.h>
> +#include <mini-os/mm.h>

Does all those includes relevant for hypercall-arm?

> diff --git a/extras/mini-os/include/arm/os.h b/extras/mini-os/include/arm/os.h
> new file mode 100644
> index 0000000..bde8796
> --- /dev/null
> +++ b/extras/mini-os/include/arm/os.h

[..]

> +#define BUG() while(1){}

It looks odd to use onely while (1). Shouldn't you call do_exit as x86 does?

-- 
Julien Grall