From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbaF0L1B (ORCPT ); Fri, 27 Jun 2014 07:27:01 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:40883 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbaF0L07 (ORCPT ); Fri, 27 Jun 2014 07:26:59 -0400 Message-ID: <53AD54EC.2050606@gmail.com> Date: Fri, 27 Jun 2014 13:26:36 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Chanwoo Choi , jic23@kernel.org, ch.naveen@samsung.com, t.figa@samsung.com, kgene.kim@samsung.com CC: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rdunlap@infradead.org, sachin.kamat@linaro.org, kyungmin.park@samsung.com, linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean References: <1403843406-28229-1-git-send-email-cw00.choi@samsung.com> In-Reply-To: <1403843406-28229-1-git-send-email-cw00.choi@samsung.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 27.06.2014 06:30, Chanwoo Choi wrote: > Changes from v4: > - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure > and remove enum variable of ADC version > - Fix wrong name of special clock (sclk_tsadc -> sclk_adc) > - Add reviewed message by Naveen Krishna Chatradhi > - Add functions for ADC clock control > > Changes from v3: > - Add new 'exynos_adc_ops' structure to improve readability according to > Tomasz Figa comment[1] > [1] https://lkml.org/lkml/2014/4/16/238 > - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC > - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file > > Changes from v2: > - Check return value of clock function to deal with error exception > - Fix minor coding style to improve readability > > Changes from v1: > - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC > - Add a patch about DT binding documentation > > Chanwoo Choi (4): > iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability > iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC > iio: devicetree: Add DT binding documentation for Exynos3250 ADC > ARM: dts: Fix wrong compatible string for Exynos3250 ADC > > .../devicetree/bindings/arm/samsung/exynos-adc.txt | 26 +- > arch/arm/boot/dts/exynos3250.dtsi | 4 +- > drivers/iio/adc/exynos_adc.c | 326 +++++++++++++++------ > 3 files changed, 268 insertions(+), 88 deletions(-) > For the whole series: Reviewed-by: Tomasz Figa Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Date: Fri, 27 Jun 2014 13:26:36 +0200 Message-ID: <53AD54EC.2050606@gmail.com> References: <1403843406-28229-1-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1403843406-28229-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chanwoo Choi , jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Chanwoo, On 27.06.2014 06:30, Chanwoo Choi wrote: > Changes from v4: > - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure > and remove enum variable of ADC version > - Fix wrong name of special clock (sclk_tsadc -> sclk_adc) > - Add reviewed message by Naveen Krishna Chatradhi > - Add functions for ADC clock control > > Changes from v3: > - Add new 'exynos_adc_ops' structure to improve readability according to > Tomasz Figa comment[1] > [1] https://lkml.org/lkml/2014/4/16/238 > - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC > - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file > > Changes from v2: > - Check return value of clock function to deal with error exception > - Fix minor coding style to improve readability > > Changes from v1: > - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC > - Add a patch about DT binding documentation > > Chanwoo Choi (4): > iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability > iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC > iio: devicetree: Add DT binding documentation for Exynos3250 ADC > ARM: dts: Fix wrong compatible string for Exynos3250 ADC > > .../devicetree/bindings/arm/samsung/exynos-adc.txt | 26 +- > arch/arm/boot/dts/exynos3250.dtsi | 4 +- > drivers/iio/adc/exynos_adc.c | 326 +++++++++++++++------ > 3 files changed, 268 insertions(+), 88 deletions(-) > For the whole series: Reviewed-by: Tomasz Figa Best regards, Tomasz