From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X19yJ-0000RZ-Ii for qemu-devel@nongnu.org; Sun, 29 Jun 2014 03:56:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X19yD-0006vE-DZ for qemu-devel@nongnu.org; Sun, 29 Jun 2014 03:56:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:22240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X19yD-0006uu-80 for qemu-devel@nongnu.org; Sun, 29 Jun 2014 03:56:17 -0400 Message-ID: <53AFC69A.801@intel.com> Date: Sun, 29 Jun 2014 15:56:10 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> <53AA6B2D.2030804@redhat.com> <53AD2C8E.8030009@intel.com> <53AD54FD.4010807@redhat.com> In-Reply-To: <53AD54FD.4010807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com On 2014/6/27 19:26, Paolo Bonzini wrote: > Il 27/06/2014 10:34, Chen, Tiejun ha scritto: >> >> >> So how to separate this to specific to xen? Or you mean we need to >> create an new machine to address this scenario? But actually this is >> same as xenfv_machine except for these little codes. > > Yes, please create a new machine so that "-M pc" doesn't have any of > these hacks. But regardless of the machine is 'xenfv' or 'pc', we always call pc_init_pci(), then inside, i440fx_init() is always performed. So I think even we create a new machine, shouldn't we still call pc_init_pci()? > > Note that "-M xenfv" is obsolete, Xen can now use "-M pc" (i.e. the > default). > Yes, Xen can use 'pc'. Thanks Tiejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough Date: Sun, 29 Jun 2014 15:56:10 +0800 Message-ID: <53AFC69A.801@intel.com> References: <1403662641-28526-1-git-send-email-tiejun.chen@intel.com> <1403662641-28526-5-git-send-email-tiejun.chen@intel.com> <53AA6B2D.2030804@redhat.com> <53AD2C8E.8030009@intel.com> <53AD54FD.4010807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53AD54FD.4010807@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Paolo Bonzini , anthony.perard@citrix.com, stefano.stabellini@eu.citrix.com, mst@redhat.com, Kelly.Zytaruk@amd.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2014/6/27 19:26, Paolo Bonzini wrote: > Il 27/06/2014 10:34, Chen, Tiejun ha scritto: >> >> >> So how to separate this to specific to xen? Or you mean we need to >> create an new machine to address this scenario? But actually this is >> same as xenfv_machine except for these little codes. > > Yes, please create a new machine so that "-M pc" doesn't have any of > these hacks. But regardless of the machine is 'xenfv' or 'pc', we always call pc_init_pci(), then inside, i440fx_init() is always performed. So I think even we create a new machine, shouldn't we still call pc_init_pci()? > > Note that "-M xenfv" is obsolete, Xen can now use "-M pc" (i.e. the > default). > Yes, Xen can use 'pc'. Thanks Tiejun