From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/3] drm/radeon: stop poisoning the GART TLB Date: Sun, 29 Jun 2014 12:34:50 +0200 Message-ID: <53AFEBCA.4060307@amd.com> References: <1401888598-1961-1-git-send-email-deathsimple@vodafone.de> <5398218A.4040104@vodafone.de> <53998D99.6050008@vodafone.de> <539B1CA0.6010600@vodafone.de> <539D9601.8090308@vodafone.de> <53A2415D.6020808@daenzer.net> <53A2B155.4000001@vodafone.de> <53A7E21E.1000000@daenzer.net> <53A7F9E1.8080700@amd.com> <53A91F89.7090504@daenzer.net> <53A94F94.6040603@amd.com> <53AA4913.10401@daenzer.net> <53ACD78C.6090102@daenzer.net> <53AD2AB8.4080902@amd.com> <53AD3261.9020206@daenzer.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060408030008010706060608" Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2lp0207.outbound.protection.outlook.com [207.46.163.207]) by gabe.freedesktop.org (Postfix) with ESMTP id 732096E2D0 for ; Sun, 29 Jun 2014 03:35:15 -0700 (PDT) In-Reply-To: <53AD3261.9020206@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?ISO-8859-1?Q?Michel_D=E4nzer?= , Alex Deucher Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org --------------060408030008010706060608 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable Am 27.06.2014 10:59, schrieb Michel D=E4nzer: > On 27.06.2014 17:26, Christian K=F6nig wrote: >> Am 27.06.2014 04:31, schrieb Michel D=E4nzer: >>> On 25.06.2014 12:59, Michel D=E4nzer wrote: >>>> With these patches, 3.15 just survived two piglit runs on my Bonaire= , >>>> one with the GART poisoning fix and one without. It never survived a >>>> single run before. >>>> >>>> Acked-and-Tested-by: Michel D=E4nzer >>> So, are these patches going to 3.16 and 3.15? >> We could send them in for 3.15, > What's the alternative for 3.15? Well, figuring out what's the real reason behind those lockups would be=20 a good start :) > Looks like e.g. https://bugs.freedesktop.org/show_bug.cgi?id=3D80141 is > confirmed to be this. > > >> but for 3.16 we have some new features that depend on the new code. >> >> We could backport them to the old code, but I really want to work on >> figuring out what's wrong with the new approach instead. >> >> Going to prepare a branch for you to test over the weekend, would be >> nice if you could give it a try on Monday and see if that fixes the >> issues as well. > Sure, will do. I've just pushed the branch testing-3.15 to=20 git://people.freedesktop.org/~deathsimple/linux. It's based on 3.15.2=20 and contains the "stop poisoning the GART TLB" patch backported to 3.15=20 and a couple of things that I would like to try. I've disabled the redirection of page faults to the dummy page for now=20 and so the system should lockup on the first page fault it encounters.=20 Apart from that the page directory and page tables are now completely=20 over allocated and over aligned. Setting the READABLE bit on invalid entries shouldn't have an effect=20 other than making those entries non zero. So please try to lockup your=20 bonaire with this branch and as soon as you encounter the first page=20 fault take a look at VM_CONTEXT1_PROTECTION_FAULT_STATUS and figure out=20 which VMID caused the lockup. Then use the attached script to make a dump from the complete page=20 directory and page table of the VMID in question. E.g. "./dump_vm.sh 1"=20 if the lockup was caused by VMID 1 etc... Make sure you've got a=20 radeontool that supports CIK, otherwise it would only return zeros as=20 page directory address. Since even the invalid page table entries should now have at least the=20 READABLE bit set there shouldn't be anything zero in this dump and look=20 out for anything else suspicious as well (0xdeadbeef etc...). Thanks for the help, Christian. --------------060408030008010706060608 Content-Type: application/x-shellscript; name="dump_vm.sh" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="dump_vm.sh" IyEvYmluL2Jhc2gKClZNPSQxCgppZiBbICRWTSAtbHQgOCBdOyB0aGVuCglSRUc9JCgoMHgx NTNjICsgJFZNICogNCkpCmVsc2UKCVJFRz0kKCgweDE0MzggKyAoJFZNIC0gOCkgKiA0KSkK ZmkKClJFRz0kKHByaW50ZiAiMHgleCIgJFJFRykKCkFERFI9JChzdWRvIC91c3Ivc3JjL3Jh ZGVvbnRvb2wvcmFkZW9ucmVnIC0tc2tpcD0wIHJlZ21hdGNoICRSRUcgfCBjdXQgLWMgOC0x NykKClZSQU09L3N5cy9rZXJuZWwvZGVidWcvZHJpLzAvcmFkZW9uX3ZyYW0KCnN1ZG8gaGV4 ZHVtcCAtcyAke0FERFJ9MDAwIC1uIDQwOTYgLWUgJyIlMDEwLjEwX2F4ICAiIDIvNCAiJTA4 eCAiICJcbiInICRWUkFNIHwgd2hpbGUgcmVhZCBsCmRvCgllY2hvICIkbCIKCUFERFI9JChl Y2hvICIkbCIgfCBjdXQgLWMgMTMtMTcpCglpZiBbICIkVk0iIC1uZSAwIC1hICIkQUREUiIg IT0gIjAwMDAwIiAtYSAiJEFERFIiICE9ICIiIF07IHRoZW4KCQlzdWRvIGhleGR1bXAgLXMg MHgke0FERFJ9MDAwIC1uIDQwOTYgLWUgJyIgICAlMDEwLjEwX2F4ICAiIDIvNCAiJTA4eCAi ICJcbiInICRWUkFNCglmaQpkb25lCg== --------------060408030008010706060608 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------060408030008010706060608--