From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbaF2Nfq (ORCPT ); Sun, 29 Jun 2014 09:35:46 -0400 Received: from mail.kernel.org ([198.145.19.201]:54988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211AbaF2Nfo (ORCPT ); Sun, 29 Jun 2014 09:35:44 -0400 Message-ID: <53B016AD.3020008@kernel.org> Date: Sun, 29 Jun 2014 14:37:49 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Federico Di Pierro , Greg Kroah-Hartman , Jingoo Han , Sachin Kamat CC: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: iio: Coding style issues fix. References: <1404034862-5789-1-git-send-email-nierro92@gmail.com> In-Reply-To: <1404034862-5789-1-git-send-email-nierro92@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/14 10:41, Federico Di Pierro wrote: > Fix some little style issues in drivers/staging/iio/frequency/ad9832.c . > This is my latest task of the eudyptula challenge (third attempt!) > > Signed-off-by: Federico Di Pierro I'd have preferred more meaty work on this driver, but I guess every little bit helps... Applied to the togreg branch of iio.git Thanks, > --- > drivers/staging/iio/frequency/ad9832.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c > index c7d0307..b7c8351 100644 > --- a/drivers/staging/iio/frequency/ad9832.c > +++ b/drivers/staging/iio/frequency/ad9832.c > @@ -57,7 +57,7 @@ static int ad9832_write_frequency(struct ad9832_state *st, > } > > static int ad9832_write_phase(struct ad9832_state *st, > - unsigned long addr, unsigned long phase) > + unsigned long addr, unsigned long phase) > { > if (phase > (1 << AD9832_PHASE_BITS)) > return -EINVAL; > @@ -72,10 +72,8 @@ static int ad9832_write_phase(struct ad9832_state *st, > return spi_sync(st->spi, &st->phase_msg); > } > > -static ssize_t ad9832_write(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > +static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t len) > { > struct iio_dev *indio_dev = dev_to_iio_dev(dev); > struct ad9832_state *st = iio_priv(indio_dev); > @@ -109,11 +107,11 @@ static ssize_t ad9832_write(struct device *dev, > ret = spi_sync(st->spi, &st->msg); > break; > case AD9832_FREQ_SYM: > - if (val == 1) > + if (val == 1) { > st->ctrl_fp |= AD9832_FREQ; > - else if (val == 0) > + } else if (val == 0) { > st->ctrl_fp &= ~AD9832_FREQ; > - else { > + } else { > ret = -EINVAL; > break; > } >