All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Jan Beulich <JBeulich@suse.com>, vijay.kilari@gmail.com
Cc: keir@xen.org, Ian.Campbell@citrix.com,
	stefano.stabellini@eu.citrix.com,
	Prasun.Kapoor@caviumnetworks.com,
	Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
	julien.grall@linaro.org, tim@xen.org, george.dunlap@citrix.com,
	xen-devel@lists.xen.org, stefano.stabellini@citrix.com
Subject: Re: [PATCH v7a 09/14] xen/arm: move and rename is_vcpu_running function to sched.h
Date: Tue, 1 Jul 2014 10:32:36 +0100	[thread overview]
Message-ID: <53B28034.4060404@eu.citrix.com> (raw)
In-Reply-To: <53B285A8020000780001EDA8@mail.emea.novell.com>

On 07/01/2014 08:55 AM, Jan Beulich wrote:
>>>> On 01.07.14 at 08:41, <vijay.kilari@gmail.com> wrote:
>> @@ -829,6 +829,20 @@ void watchdog_domain_destroy(struct domain *d);
>>   #define need_iommu(d)    (0)
>>   #endif
>>
>> +static inline bool_t is_vcpu_online(const struct domain *d, unsigned int vcpuid)
>
> I'm sorry for paying attention to this only now, but a function named
> this way would ordinarily have a single const struct vcpu * parameter.
> If the decoding of the (domain, vcpuid) tuple is to remain in the
> function I guess it ought to be renamed to e.g. is_domain_vcpu_online()

+1

> (I'd further suggest to drop the is_ prefix, but I realize others may be
> of different opinion).

I'd probably be of the "keep the is_" opinion. :-)

  -George

  reply	other threads:[~2014-07-01  9:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  6:41 [PATCH v7a 00/14] GIC and VGIC code refactoring vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 01/14] xen/arm: make sgi handling generic vijay.kilari
2014-07-01 11:13   ` Julien Grall
2014-07-02 10:51     ` Ian Campbell
2014-07-01  6:41 ` [PATCH v7a 02/14] xen/arm: use ioremap to map gic-v2 registers vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 03/14] xen/arm: segregate and split GIC low level functionality vijay.kilari
2014-07-01 11:32   ` Julien Grall
2014-07-01  6:41 ` [PATCH v7a 04/14] xen/arm: move GIC context data structure to gic driver vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 05/14] xen/arm: use device api to detect GIC version vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 06/14] xen/arm: switch to dynamic allocation of vgic rank vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 07/14] xen/arm: prefix byte_read and byte_write functions with vgic vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 08/14] xen/arm: move vgic defines to vgic header file vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 09/14] xen/arm: move and rename is_vcpu_running function to sched.h vijay.kilari
2014-07-01  7:55   ` Jan Beulich
2014-07-01  9:32     ` George Dunlap [this message]
2014-07-02 11:19     ` Ian Campbell
2014-07-02 13:03       ` Vijay Kilari
2014-07-01  6:41 ` [PATCH v7a 10/14] xen/arm: move pending_irq structure to vgic header file vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 11/14] xen/arm: calculate vgic irq rank based on register size vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 12/14] xen/arm: Remove REG macro in vgic driver vijay.kilari
2014-07-01  6:41 ` [PATCH v7a 13/14] xen/arm: split vgic driver into generic and vgic-v2 driver vijay.kilari
2014-07-01 13:08   ` Julien Grall
2014-07-02  6:39     ` Vijay Kilari
2014-07-02  9:01       ` Julien Grall
2014-07-01  6:41 ` [PATCH v7a 14/14] xen/arm: Restrict saving of gic register for idle domain vijay.kilari
2014-07-04 14:25   ` Stefano Stabellini
2014-07-01 11:06 ` [PATCH v7a 00/14] GIC and VGIC code refactoring Julien Grall
2014-07-02 11:41 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B28034.4060404@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=Vijaya.Kumar@caviumnetworks.com \
    --cc=george.dunlap@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.