All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] systemd: bump to version 214
Date: Wed, 02 Jul 2014 07:30:38 +0200	[thread overview]
Message-ID: <53B398FE.9030200@mind.be> (raw)
In-Reply-To: <1404070537-14255-1-git-send-email-eric.le.bihan.dev@free.fr>

On 29/06/14 21:35, Eric Le Bihan wrote:
> This patch bumps systemd to version 214.
> 
> Changes:
> 
> - add new users: systemd-bus-proxy, systemd-network and systemd-resolve.
> - remove gtk-doc patch, as it is no longer needed.
> - force kmod path when configuring.
> - remove attr build dependency.
> 
> Besides:
> 
> - /var/lock no longer needs to be a symlink to /run, as systemd, via
>   tmpfiles.d, will automatically create a symlink to /run/lock at
>   runtime.
> - when using systemd-networkd, /etc/resolv.conf should now be a symlink
>   to /run/systemd/resolve/resolv.conf.

 So, maybe the systemd package should make sure that this is the case? In a
post-install hook for instance?

> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
[snip]
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 95e7214..947bc92 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -SYSTEMD_VERSION = 213
> +SYSTEMD_VERSION = 214
>  SYSTEMD_SITE = http://www.freedesktop.org/software/systemd/
>  SYSTEMD_SOURCE = systemd-$(SYSTEMD_VERSION).tar.xz
>  SYSTEMD_LICENSE = LGPLv2.1+; GPLv2+ for udev; MIT-like license for few source files listed in README
> @@ -50,6 +50,9 @@ SYSTEMD_CONF_OPT += \
>  	--disable-dbus \
>  	--without-python
>  
> +SYSTEMD_CONF_ENV = \
> +	ac_cv_path_KMOD=/usr/bin/kmod

 Since we would normally expect this to point into $(HOST_DIR), I think there
should be a comment here.

> +
>  ifeq ($(BR2_PACKAGE_SYSTEMD_COMPAT),y)
>  SYSTEMD_CONF_OPT += --enable-compat-libs
>  else
> @@ -65,7 +68,6 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_ATTR),y)
>  SYSTEMD_CONF_OPT += --enable-attr
> -SYSTEMD_DEPENDENCIES += attr

 Uh? How is it possible to do --enable-attr without depending on attr? Run-time
dependency only? Then this should be explained in a comment.

>  else
>  SYSTEMD_CONF_OPT += --disable-attr
>  endif
> @@ -99,6 +101,9 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
>  SYSTEMD_CONF_OPT += --enable-networkd
> +define SYSTEMD_USER_TIMESYNC

 I don't suppose timesync and networkd are mutually exclusive, so this should be
SYSTEMD_USER_NETWORK and it should be added to SYSTEMD_USERS, below.


 Regards,
 Arnout


> +	systemd-network -1 systemd-network -1 * - - - Network Manager
> +endef
>  else
>  SYSTEMD_CONF_OPT += --disable-networkd
>  define SYSTEMD_INSTALL_SERVICE_NETWORK
> @@ -155,6 +160,8 @@ SYSTEMD_POST_INSTALL_TARGET_HOOKS += \
>  define SYSTEMD_USERS
>  	systemd-journal -1 systemd-journal -1 * /var/log/journal - - Journal
>  	systemd-journal-gateway -1 systemd-journal-gateway -1 * /var/log/journal - - Journal Gateway
> +	systemd-resolve -1 systemd-resolve -1 * - - - Network Name Resolution Manager
> +	systemd-bus-proxy -1 systemd-bus-proxy -1 * - - - Proxy D-Bus messages to/from a bus
>  	$(SYSTEMD_USER_TIMESYNC)
>  endef
>  
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2014-07-02  5:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29 19:35 [Buildroot] [PATCH 1/1] systemd: bump to version 214 Eric Le Bihan
2014-07-01 21:27 ` Thomas Petazzoni
2014-07-02  5:30 ` Arnout Vandecappelle [this message]
2014-07-02 18:08   ` Eric Le Bihan
2014-07-02 19:09     ` Arnout Vandecappelle
2014-07-03 11:21 ` Thomas Petazzoni
2014-07-04 19:25   ` Arnout Vandecappelle
2014-07-04 21:19     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B398FE.9030200@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.