From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2LRI-0001OT-B7 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 10:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2LRC-0007gh-I0 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 10:23:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2LRC-0007gV-8Q for qemu-devel@nongnu.org; Wed, 02 Jul 2014 10:23:06 -0400 Message-ID: <53B415C3.2000804@redhat.com> Date: Wed, 02 Jul 2014 08:22:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403857452-23768-1-git-send-email-cnanakos@grnet.gr> <1403857452-23768-5-git-send-email-cnanakos@grnet.gr> <53B41018.6040208@redhat.com> <53B41315.8080306@grnet.gr> In-Reply-To: <53B41315.8080306@grnet.gr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ExlqEOdktoorClWP07xNmX3nNl5lTlSLe" Subject: Re: [Qemu-devel] [PATCH v6 4/5] QMP: Add support for Archipelago List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ExlqEOdktoorClWP07xNmX3nNl5lTlSLe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/02/2014 08:11 AM, Chrysostomos Nanakos wrote: > On 07/02/2014 04:58 PM, Eric Blake wrote: >> On 06/27/2014 02:24 AM, Chrysostomos Nanakos wrote: >>> Introduce new enum BlockdevOptionsArchipelago. >>> >>> @@ -1347,6 +1379,7 @@ >>> 'base': 'BlockdevOptionsBase', >>> 'discriminator': 'driver', >>> 'data': { >>> + 'archipelago':'BlockdevOptionsArchipelago', >> Again, not necessarily your fault, but we ought to do a better job of >> documenting when new union branches are added in later releases. >=20 > Any proposition for this one? Here's what was done for NetClientOptions: # Since 1.2 # # 'l2tpv3' - since 2.1 although doing it properly would best be done as a separate patch that audits all qapi types. I'm not trying to force you to take on the documentation cleanup patch, although getting just your addition to mention when it was added will make that cleanup audit easier for whoever takes that task on. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ExlqEOdktoorClWP07xNmX3nNl5lTlSLe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTtBXDAAoJEKeha0olJ0NqRuMH/iOTOtstD8YeWd838soXTa5Z ldZg3efmnVkhzsZR4knqtJRl7ahiNQdPxQLTSHB/zJP1JCY24ku73FI2IRikTuA8 9mQKZGyIcHRdctAqzfygzp6kq4q2KQlhsfqTh0i5F1exHGHalMB6At6xpYscSvhN 3pAck5GB2IKiupR/7QOgpLIWoSKdob8NlvQ3BxkWqO4jxeCt1pFMpiZO2ewKE9vY AMLrZh3kg0Q0Md4xlS9zF9CXCdg2yXo50DmIXINuiWFAnBqaBu5ZL4nuH+KlPOJw 41iqtVFtSkOrX7x+7SRhTX0LJXJO8stCso8EXYsjK1lzoUrzVk81jaEJgkitvkc= =B43N -----END PGP SIGNATURE----- --ExlqEOdktoorClWP07xNmX3nNl5lTlSLe--