From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@infradead.org>
Cc: James Bottomley <jbottomley@parallels.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] ib_srp: 64bit LUN fixes
Date: Fri, 04 Jul 2014 16:41:24 +0200 [thread overview]
Message-ID: <53B6BD14.5050606@suse.de> (raw)
In-Reply-To: <53B6BC72.6040204@acm.org>
On 07/04/2014 04:38 PM, Bart Van Assche wrote:
> On 07/04/14 16:12, Hannes Reinecke wrote:
>> On 07/04/2014 03:48 PM, Christoph Hellwig wrote:
>>> I think storing the struct scsi_lun in the scsi_device is the right way
>>> to go ahead. Any "accessors" for 8 or 32-bit LUNs should be simply
>>> enough by just ignoring bits in the array, so there's very little
>>> performance overhead.
>>>
>>> If we can get rid of the old scalar LUN field that would be great,
>>> and given that we know the printk format fallout already it doesn't look
>>> like too much work. Do you want to look into this?
>>
>> Already working on it.
>
> That sounds great. Regarding the SRP initiator driver: if the "__be64
> lun" declarations in <scsi/srp.h> are changed into "struct scsi_lun lun"
> then that allows to encode / decode LUNs inside the SRP initiator
> without having to cast the address of these "lun" members into struct
> scsi_lun *. In case you would prefer me to have a look into this, please
> let me know.
>
That would be perfect.
Most of the HBAs supporting 64bit LUNs internally are already doing
this.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-04 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 11:54 [PATCH 0/2] Fixed for 64bit LUNs Hannes Reinecke
2014-07-04 11:54 ` [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers Hannes Reinecke
2014-07-04 13:44 ` Christoph Hellwig
2014-07-04 14:12 ` Hannes Reinecke
2014-07-05 9:41 ` Christoph Hellwig
2014-07-07 7:54 ` Hannes Reinecke
2014-07-07 7:59 ` Hannes Reinecke
2014-07-07 9:37 ` Christoph Hellwig
2014-07-07 10:05 ` Hannes Reinecke
2014-07-07 10:11 ` Christoph Hellwig
2014-07-07 14:10 ` Hannes Reinecke
2014-07-04 19:44 ` Douglas Gilbert
2014-07-04 20:14 ` Elliott, Robert (Server Storage)
2014-07-07 5:47 ` Hannes Reinecke
2014-07-04 11:54 ` [PATCH 2/2] ib_srp: 64bit LUN fixes Hannes Reinecke
2014-07-04 12:31 ` Bart Van Assche
2014-07-04 13:01 ` Hannes Reinecke
2014-07-04 13:48 ` Christoph Hellwig
2014-07-04 14:12 ` Hannes Reinecke
2014-07-04 14:38 ` Bart Van Assche
2014-07-04 14:41 ` Hannes Reinecke [this message]
2014-07-04 16:53 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6BD14.5050606@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.