From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RESEND PATCH v7 3/4] arm: dirty log write protect management support Date: Fri, 04 Jul 2014 18:29:31 +0200 Message-ID: <53B6D66B.9070608@redhat.com> References: <1401837567-5527-1-git-send-email-m.smarduch@samsung.com> <1402076021-9425-1-git-send-email-m.smarduch@samsung.com> <20140608120522.GG3279@lvm> <539663A0.9080507@samsung.com> <20140610092240.GF1388@lvm> <53974998.70001@samsung.com> <20140611070352.GC24286@lvm> <53A0EE60.6030508@samsung.com> <20140703150401.GE20104@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, xiaoguangrong@linux.vnet.ibm.com, steve.capper@arm.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gavin.guo@canonical.com, peter.maydell@linaro.org, jays.lee@samsung.com, sungjinn.chung@samsung.com To: Christoffer Dall , Mario Smarduch Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44863 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755595AbaGDQaT (ORCPT ); Fri, 4 Jul 2014 12:30:19 -0400 In-Reply-To: <20140703150401.GE20104@cbox> Sender: kvm-owner@vger.kernel.org List-ID: Il 03/07/2014 17:04, Christoffer Dall ha scritto: > Hmmm, I'm really not an expert in the 'established procedures' for what > to put in config files etc., but here's my basic take: > > a) you wouldn't put a config option in Kconfig unless it's comething > that's actually configurable or some generic feature/subsystem that > should only be enabled if hardware has certain capabilities or other > config options enabled. > > b) this seems entirely an implementation issue and not depending on > anything users should select. Actually I think Mario's idea is just fine. Non-user-accessible Kconfig symbols are used a lot to invoke an #ifdef elsewhere in the code; compare this with his proposal is a bit different but not too much. Sometimes #defines are used, sometimes Kconfig symbols, but the idea is the same. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: pbonzini@redhat.com (Paolo Bonzini) Date: Fri, 04 Jul 2014 18:29:31 +0200 Subject: [RESEND PATCH v7 3/4] arm: dirty log write protect management support In-Reply-To: <20140703150401.GE20104@cbox> References: <1401837567-5527-1-git-send-email-m.smarduch@samsung.com> <1402076021-9425-1-git-send-email-m.smarduch@samsung.com> <20140608120522.GG3279@lvm> <539663A0.9080507@samsung.com> <20140610092240.GF1388@lvm> <53974998.70001@samsung.com> <20140611070352.GC24286@lvm> <53A0EE60.6030508@samsung.com> <20140703150401.GE20104@cbox> Message-ID: <53B6D66B.9070608@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Il 03/07/2014 17:04, Christoffer Dall ha scritto: > Hmmm, I'm really not an expert in the 'established procedures' for what > to put in config files etc., but here's my basic take: > > a) you wouldn't put a config option in Kconfig unless it's comething > that's actually configurable or some generic feature/subsystem that > should only be enabled if hardware has certain capabilities or other > config options enabled. > > b) this seems entirely an implementation issue and not depending on > anything users should select. Actually I think Mario's idea is just fine. Non-user-accessible Kconfig symbols are used a lot to invoke an #ifdef elsewhere in the code; compare this with his proposal is a bit different but not too much. Sometimes #defines are used, sometimes Kconfig symbols, but the idea is the same. Paolo