From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X45mD-0006h4-NX for qemu-devel@nongnu.org; Mon, 07 Jul 2014 06:04:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X45m8-00051j-TW for qemu-devel@nongnu.org; Mon, 07 Jul 2014 06:04:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X45m8-00051S-LB for qemu-devel@nongnu.org; Mon, 07 Jul 2014 06:03:56 -0400 Message-ID: <53BA7079.5050704@redhat.com> Date: Mon, 07 Jul 2014 12:03:37 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com> <20140707092903.GA20212@redhat.com> In-Reply-To: <20140707092903.GA20212@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , arei.gonglei@huawei.com Cc: peter.maydell@linaro.org, weidong.huang@huawei.com, Chenliang , aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, kraxel@redhat.com, dmitry@daynix.com, akong@redhat.com, armbru@redhat.com, marcel.a@redhat.com, somlo@cmu.edu, luonengjun@huawei.com, peter.huangpeng@huawei.com, alex.williamson@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, peter.crosthwaite@xilinx.com, imammedo@redhat.com, afaerber@suse.de On 07/07/14 11:29, Michael S. Tsirkin wrote: > On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gonglei@huawei.com wrote: >> From: Chenliang >> >> Sometime, we want to modify boot order of vm without shutdown it. >> This sets of patches add one qmp to achieve it. And fix some little >> bug when device is hotpluged. >> >> Chenliang (5): >> bootindex: add *_boot_device_path function >> bootindex: reset bootindex when vm reset >> bootindex: delete boot index when device is removed >> bootindex: add qmp to set boot index when vm is running >> bootindex: fix memory leak when ppc sets boot index > > Unfortunately at least for PC, boot order is exposed > in fw cfg which can not change while guest is running. > I suspect we need to change how we report boot order to guests. > While we are at it, maybe we can fix the silly bootindex > convention: I think people really want to specify boot *order*, > not boot index. Please preserve the "bootorder" fw_cfg file, and its format. I don't have any request in relation to the new (== dynamic) feature ATM. Thanks Laszlo