From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4A5t-00023U-BJ for qemu-devel@nongnu.org; Mon, 07 Jul 2014 10:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4A5f-0004q4-WB for qemu-devel@nongnu.org; Mon, 07 Jul 2014 10:40:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4A5f-0004pl-NX for qemu-devel@nongnu.org; Mon, 07 Jul 2014 10:40:23 -0400 Message-ID: <53BAB142.2060303@redhat.com> Date: Mon, 07 Jul 2014 16:40:02 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com> <20140707092903.GA20212@redhat.com> <53BA7079.5050704@redhat.com> <33183CC9F5247A488A2544077AF1902086C18E2D@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086C18E2D@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "Michael S. Tsirkin" Cc: "peter.maydell@linaro.org" , "Huangweidong (C)" , "chenliang (T)" , "aik@ozlabs.ru" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "kraxel@redhat.com" , "dmitry@daynix.com" , "akong@redhat.com" , "armbru@redhat.com" , "marcel.a@redhat.com" , "somlo@cmu.edu" , Luonengjun , "Huangpeng (Peter)" , "alex.williamson@redhat.com" , "stefanha@redhat.com" , "pbonzini@redhat.com" , "lcapitulino@redhat.com" , "rth@twiddle.net" , "kwolf@redhat.com" , "peter.crosthwaite@xilinx.com" , "imammedo@redhat.com" , "afaerber@suse.de" On 07/07/14 13:12, Gonglei (Arei) wrote: > > > > > > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Monday, July 07, 2014 6:04 PM >> To: Michael S. Tsirkin; Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; afaerber@suse.de; agraf@suse.de; >> stefanha@redhat.com; akong@redhat.com; aik@ozlabs.ru; >> alex.williamson@redhat.com; armbru@redhat.com; eblake@redhat.com; >> kwolf@redhat.com; peter.maydell@linaro.org; lcapitulino@redhat.com; >> pbonzini@redhat.com; kraxel@redhat.com; imammedo@redhat.com; >> dmitry@daynix.com; marcel.a@redhat.com; peter.crosthwaite@xilinx.com; >> rth@twiddle.net; somlo@cmu.edu; Huangweidong (C); Luonengjun; >> Huangpeng (Peter); chenliang (T) >> Subject: Re: [RFC PATCH 0/5] modify boot order when vm is running >> >> On 07/07/14 11:29, Michael S. Tsirkin wrote: >>> On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gonglei@huawei.com >> wrote: >>>> From: Chenliang >>>> >>>> Sometime, we want to modify boot order of vm without shutdown it. >>>> This sets of patches add one qmp to achieve it. And fix some little >>>> bug when device is hotpluged. >>>> >>>> Chenliang (5): >>>> bootindex: add *_boot_device_path function >>>> bootindex: reset bootindex when vm reset >>>> bootindex: delete boot index when device is removed >>>> bootindex: add qmp to set boot index when vm is running >>>> bootindex: fix memory leak when ppc sets boot index >>> >>> Unfortunately at least for PC, boot order is exposed >>> in fw cfg which can not change while guest is running. >>> I suspect we need to change how we report boot order to guests. >>> While we are at it, maybe we can fix the silly bootindex >>> convention: I think people really want to specify boot *order*, >>> not boot index. >> >> Please preserve the "bootorder" fw_cfg file, and its format. >> >> I don't have any request in relation to the new (== dynamic) feature ATM. >> > Sorry, I can't understand your meaning exactly. > Would you explain it? Thanks! I meant that whatever features you introduce, please make sure that a guest looking for the "bootorder" fw_cfg file will find it, and that the contents and the format of that fw_cfg file stays the same, for the same qemu command line options. I'm not implying that your current series changes the "bootorder" fw_cfg file (I have not looked at your patches); this is just a general request I make out of caution. Thanks Laszlo