From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH 0/2] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Date: Tue, 8 Jul 2014 09:32:38 +0100 Message-ID: <53BBACA6.9040007@citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xensource.com Cc: v1ne2go@gmail.com, David Vrabel , Ian Campbell List-Id: xen-devel@lists.xenproject.org Hi Stefano, (Drop Linux ARM as my comment is only Xen specific and avoid spamming the Linux ML) On 07/07/14 21:24, Stefano Stabellini wrote: > diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h > index eac8a70..95519c5 100644 > --- a/xen/include/asm-arm/grant_table.h > +++ b/xen/include/asm-arm/grant_table.h > @@ -34,7 +34,7 @@ static inline int replace_grant_supported(void) > (i < max_nr_grant_frames)) ? 0 : (d->arch.grant_table_gpfn[i])) > > #define gnttab_need_iommu_mapping(d) \ > - (is_domain_direct_mapped(d) && need_iommu(d)) > + (is_domain_direct_mapped(d)) I suspect you tried this series on Midway with SMMU enabled, right? This patch won't work on platform with iommu disabled (see check in iommu_{,un}map_page) and if we are using an other driver than the SMMU. This is because the mapping is drivers specific. > #endif /* __ASM_GRANT_TABLE_H__ */ > /* -- Julien Grall