From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH 2/2] t/Makefile: always test all lint targets when running tests
Date: Tue, 08 Jul 2014 21:24:25 +0200 [thread overview]
Message-ID: <53BC4569.3020907@web.de> (raw)
In-Reply-To: <xmqq38eddolk.fsf@gitster.dls.corp.google.com>
Am 07.07.2014 20:13, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> Only the two targets "test-lint-duplicates" and "test-lint-executable" are
>> currently executed when running the test target. This was done on purpose
>> when the TEST_LINT variable was added in 81127d74. But as this does not
>> include the "test-lint-shell-syntax" target added the same day in commit
>> c7ce70ac, it is easy to accidentally add non portable shell constructs
>> without noticing that when running the test suite.
>
> I not running the lint-shell-syntax that is fundamentally flaky to
> avoid false positives is very much on purpose. The flakiness is not
> the fault of the implementor of the lint-shell-syntax, but comes
> from the approach taken to pretend that simple pattern matching can
> parse shell scripts. It may not complain on the current set of
> scripts, but that is not really by design but by accident.
>
> So I am not very enthusiastic to see this change myself.
Ok, I understand we do not want to lightly risk false positives. I
just noticed that I accidentally forgot to sign off this series, so
I'd resend just the first patch with a proper SOB, ok?
next prev parent reply other threads:[~2014-07-08 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 22:19 [PATCH 0/2] always run all lint targets when running the test suite Jens Lehmann
2014-07-03 22:20 ` [PATCH 1/2] t/Makefile: check helper scripts for non-portable shell commands too Jens Lehmann
2014-07-03 22:21 ` [PATCH 2/2] t/Makefile: always test all lint targets when running tests Jens Lehmann
2014-07-07 18:13 ` Junio C Hamano
2014-07-08 19:24 ` Jens Lehmann [this message]
2014-07-09 5:42 ` Junio C Hamano
2014-07-09 19:33 ` [PATCH v2 0/2] always run all lint targets when running the test suite Jens Lehmann
2014-07-09 19:34 ` [PATCH v2 1/2] t/Makefile: check helper scripts for non-portable shell commands too Jens Lehmann
2014-07-09 19:34 ` [PATCH v2 2/2] t/Makefile: always test all lint targets when running tests Jens Lehmann
2014-07-09 5:30 ` [PATCH " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC4569.3020907@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.