From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [RFC v2 3/5] clk: use struct clk only for external API Date: Wed, 09 Jul 2014 22:12:13 +0200 Message-ID: <53BDA21D.3070504@gmail.com> References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> <1404398323-18934-4-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404398323-18934-4-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomeu Vizoso , Stephen Warren , Thierry Reding , Mike Turquette , rabin-66gdRtMMWGc@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Rabin Vincent , Javier Martinez Canillas List-Id: linux-tegra@vger.kernel.org Actually few more comments, see inline. On 03.07.2014 16:38, Tomeu Vizoso wrote: > From: Rabin Vincent > > In order to provide per-user accounting, this separates the struct clk > used in the common clock framework into two structures 'struct clk_core' > and 'struct clk'. struct clk_core will be used for internal > manipulation and struct clk will be used in the clock API > implementation. [snip] > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c > index 8f57154..5f2aba9 100644 > --- a/drivers/clk/clk-devres.c > +++ b/drivers/clk/clk-devres.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -14,15 +15,15 @@ static void devm_clk_release(struct device *dev, void *res) > clk_put(*(struct clk **)res); This function still expects to get a (struct clk *) here, but... > } > > -struct clk *devm_clk_get(struct device *dev, const char *id) > +struct clk_core *devm_clk_provider_get(struct device *dev, const char *id) > { > - struct clk **ptr, *clk; > + struct clk_core **ptr, *clk; > > ptr = devres_alloc(devm_clk_release, sizeof(*ptr), GFP_KERNEL); > if (!ptr) > return ERR_PTR(-ENOMEM); > > - clk = clk_get(dev, id); > + clk = clk_provider_get(dev, id); > if (!IS_ERR(clk)) { > *ptr = clk; ...here a (struct clk_core *) is stored. > devres_add(dev, ptr); [snip] > diff --git a/drivers/clk/clk.h b/drivers/clk/clk.h > index d278572..c69f4fe 100644 > --- a/drivers/clk/clk.h > +++ b/drivers/clk/clk.h > @@ -15,3 +15,7 @@ struct clk_core *__of_clk_get_from_provider(struct of_phandle_args *clkspec); > void of_clk_lock(void); > void of_clk_unlock(void); > #endif > + > +#if defined(CONFIG_COMMON_CLK) > +#define clk_to_clk_core(clk) (clk->core) Making this a static inline will benefit you with type checking at compilation time. > +#endif [snip] > + > +#define clk_core_to_clk(core) ((struct clk *)(core)) Hmm, I'm not following. clk_to_clk_core() returns clk->core, while clk_core_to_clk() simply casts whatever the former returns into a pointer to struct clk? Also this should be a static inline to benefit from compiler type checking. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674AbaGIUMg (ORCPT ); Wed, 9 Jul 2014 16:12:36 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:57162 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbaGIUMe (ORCPT ); Wed, 9 Jul 2014 16:12:34 -0400 Message-ID: <53BDA21D.3070504@gmail.com> Date: Wed, 09 Jul 2014 22:12:13 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tomeu Vizoso , Stephen Warren , Thierry Reding , Mike Turquette , rabin@rab.in, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org CC: Rabin Vincent , Javier Martinez Canillas Subject: Re: [RFC v2 3/5] clk: use struct clk only for external API References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> <1404398323-18934-4-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1404398323-18934-4-git-send-email-tomeu.vizoso@collabora.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually few more comments, see inline. On 03.07.2014 16:38, Tomeu Vizoso wrote: > From: Rabin Vincent > > In order to provide per-user accounting, this separates the struct clk > used in the common clock framework into two structures 'struct clk_core' > and 'struct clk'. struct clk_core will be used for internal > manipulation and struct clk will be used in the clock API > implementation. [snip] > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c > index 8f57154..5f2aba9 100644 > --- a/drivers/clk/clk-devres.c > +++ b/drivers/clk/clk-devres.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -14,15 +15,15 @@ static void devm_clk_release(struct device *dev, void *res) > clk_put(*(struct clk **)res); This function still expects to get a (struct clk *) here, but... > } > > -struct clk *devm_clk_get(struct device *dev, const char *id) > +struct clk_core *devm_clk_provider_get(struct device *dev, const char *id) > { > - struct clk **ptr, *clk; > + struct clk_core **ptr, *clk; > > ptr = devres_alloc(devm_clk_release, sizeof(*ptr), GFP_KERNEL); > if (!ptr) > return ERR_PTR(-ENOMEM); > > - clk = clk_get(dev, id); > + clk = clk_provider_get(dev, id); > if (!IS_ERR(clk)) { > *ptr = clk; ...here a (struct clk_core *) is stored. > devres_add(dev, ptr); [snip] > diff --git a/drivers/clk/clk.h b/drivers/clk/clk.h > index d278572..c69f4fe 100644 > --- a/drivers/clk/clk.h > +++ b/drivers/clk/clk.h > @@ -15,3 +15,7 @@ struct clk_core *__of_clk_get_from_provider(struct of_phandle_args *clkspec); > void of_clk_lock(void); > void of_clk_unlock(void); > #endif > + > +#if defined(CONFIG_COMMON_CLK) > +#define clk_to_clk_core(clk) (clk->core) Making this a static inline will benefit you with type checking at compilation time. > +#endif [snip] > + > +#define clk_core_to_clk(core) ((struct clk *)(core)) Hmm, I'm not following. clk_to_clk_core() returns clk->core, while clk_core_to_clk() simply casts whatever the former returns into a pointer to struct clk? Also this should be a static inline to benefit from compiler type checking. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Wed, 09 Jul 2014 22:12:13 +0200 Subject: [RFC v2 3/5] clk: use struct clk only for external API In-Reply-To: <1404398323-18934-4-git-send-email-tomeu.vizoso@collabora.com> References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> <1404398323-18934-4-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <53BDA21D.3070504@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Actually few more comments, see inline. On 03.07.2014 16:38, Tomeu Vizoso wrote: > From: Rabin Vincent > > In order to provide per-user accounting, this separates the struct clk > used in the common clock framework into two structures 'struct clk_core' > and 'struct clk'. struct clk_core will be used for internal > manipulation and struct clk will be used in the clock API > implementation. [snip] > diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c > index 8f57154..5f2aba9 100644 > --- a/drivers/clk/clk-devres.c > +++ b/drivers/clk/clk-devres.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -14,15 +15,15 @@ static void devm_clk_release(struct device *dev, void *res) > clk_put(*(struct clk **)res); This function still expects to get a (struct clk *) here, but... > } > > -struct clk *devm_clk_get(struct device *dev, const char *id) > +struct clk_core *devm_clk_provider_get(struct device *dev, const char *id) > { > - struct clk **ptr, *clk; > + struct clk_core **ptr, *clk; > > ptr = devres_alloc(devm_clk_release, sizeof(*ptr), GFP_KERNEL); > if (!ptr) > return ERR_PTR(-ENOMEM); > > - clk = clk_get(dev, id); > + clk = clk_provider_get(dev, id); > if (!IS_ERR(clk)) { > *ptr = clk; ...here a (struct clk_core *) is stored. > devres_add(dev, ptr); [snip] > diff --git a/drivers/clk/clk.h b/drivers/clk/clk.h > index d278572..c69f4fe 100644 > --- a/drivers/clk/clk.h > +++ b/drivers/clk/clk.h > @@ -15,3 +15,7 @@ struct clk_core *__of_clk_get_from_provider(struct of_phandle_args *clkspec); > void of_clk_lock(void); > void of_clk_unlock(void); > #endif > + > +#if defined(CONFIG_COMMON_CLK) > +#define clk_to_clk_core(clk) (clk->core) Making this a static inline will benefit you with type checking at compilation time. > +#endif [snip] > + > +#define clk_core_to_clk(core) ((struct clk *)(core)) Hmm, I'm not following. clk_to_clk_core() returns clk->core, while clk_core_to_clk() simply casts whatever the former returns into a pointer to struct clk? Also this should be a static inline to benefit from compiler type checking. Best regards, Tomasz