From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [RFC v2 0/5] Per-user clock constraints Date: Wed, 09 Jul 2014 22:16:29 +0200 Message-ID: <53BDA31D.40502@gmail.com> References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404398323-18934-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomeu Vizoso , Stephen Warren , Thierry Reding , Mike Turquette , rabin-66gdRtMMWGc@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Javier Martinez Canillas List-Id: linux-tegra@vger.kernel.org Hi Tomeu, On 03.07.2014 16:38, Tomeu Vizoso wrote: > Hello, > > here is another round for commenting, not very different from the first one. > > Something I forgot to mention before is that the function rename was performed > by the scripts in: > > http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-4&id=0e983e28864229f2cd525f87d59e034c4876b233 > > As before, I have only checked that drivers/clk/ builds with allyesconfig, and > that a kernel can be built for tegra_defconfig. This is quite an interesting series. I have reviewed two of five patches and have plans to look at remaining ones, however here are few general issues I'd like to raise: - somehow I don't see patch 2/5 on LAKML. Too big? - I see the series changing particular clock drivers. A good practice would be to Cc respective driver maintainers to take a look at those changes. - please make sure that all the patches don't have checkpatch errors or significant warnings. Will try (myself or by asking someone else) to do some testing on Samsung platforms. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756275AbaGIUQw (ORCPT ); Wed, 9 Jul 2014 16:16:52 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:48956 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbaGIUQu (ORCPT ); Wed, 9 Jul 2014 16:16:50 -0400 Message-ID: <53BDA31D.40502@gmail.com> Date: Wed, 09 Jul 2014 22:16:29 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tomeu Vizoso , Stephen Warren , Thierry Reding , Mike Turquette , rabin@rab.in, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org CC: Javier Martinez Canillas Subject: Re: [RFC v2 0/5] Per-user clock constraints References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomeu, On 03.07.2014 16:38, Tomeu Vizoso wrote: > Hello, > > here is another round for commenting, not very different from the first one. > > Something I forgot to mention before is that the function rename was performed > by the scripts in: > > http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-4&id=0e983e28864229f2cd525f87d59e034c4876b233 > > As before, I have only checked that drivers/clk/ builds with allyesconfig, and > that a kernel can be built for tegra_defconfig. This is quite an interesting series. I have reviewed two of five patches and have plans to look at remaining ones, however here are few general issues I'd like to raise: - somehow I don't see patch 2/5 on LAKML. Too big? - I see the series changing particular clock drivers. A good practice would be to Cc respective driver maintainers to take a look at those changes. - please make sure that all the patches don't have checkpatch errors or significant warnings. Will try (myself or by asking someone else) to do some testing on Samsung platforms. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Wed, 09 Jul 2014 22:16:29 +0200 Subject: [RFC v2 0/5] Per-user clock constraints In-Reply-To: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> References: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <53BDA31D.40502@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomeu, On 03.07.2014 16:38, Tomeu Vizoso wrote: > Hello, > > here is another round for commenting, not very different from the first one. > > Something I forgot to mention before is that the function rename was performed > by the scripts in: > > http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-4&id=0e983e28864229f2cd525f87d59e034c4876b233 > > As before, I have only checked that drivers/clk/ builds with allyesconfig, and > that a kernel can be built for tegra_defconfig. This is quite an interesting series. I have reviewed two of five patches and have plans to look at remaining ones, however here are few general issues I'd like to raise: - somehow I don't see patch 2/5 on LAKML. Too big? - I see the series changing particular clock drivers. A good practice would be to Cc respective driver maintainers to take a look at those changes. - please make sure that all the patches don't have checkpatch errors or significant warnings. Will try (myself or by asking someone else) to do some testing on Samsung platforms. Best regards, Tomasz