All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, agross@codeaurora.org
Subject: Re: [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole
Date: Thu, 10 Jul 2014 14:38:22 +0100	[thread overview]
Message-ID: <53BE974E.6070804@linaro.org> (raw)
In-Reply-To: <53A0AE6C.7040706@codeaurora.org>

Hi Stephen,

Did bit more testing on this.

I could not reproduce this issue (across 40+ reboots) once I removed 
some of my debug, so we can ignore this patch for now, But we still need 
gsbi patch for clock.



Thanks,
srini

On 17/06/14 22:09, Stephen Boyd wrote:
> On 06/10/14 07:32, Srinivas Kandagatla wrote:
>> The use case is when we boot the platform with bootconsole enabled. What
>> I noticed is that the console gets locked sometimes up before the bootconsole
>> is disabled.
>>
>> As part of console setup in serial driver it resets that hardware which
>> is a race condition to bootconsole using the same hardware. This
>> patch adds a check to see if there is bootconsole before reseting the hardware.
>>
>> Am sure there are better ways to solve this, so marking this patch as
>> RFC. Any suggestions are welcome.
>>
>>
>
> Isn't there some way to check and wait for the hardware to be unused
> before we reset it?
>
> I recall being able to overcome this "race condition" by removing the
> printks in the serial driver setup. Does that work for you?
>

      parent reply	other threads:[~2014-07-10 13:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 14:31 [RFC PATCH 0/2] MSM/QCOM: Fix few race conditions when DEBUG_LL is enabled Srinivas Kandagatla
2014-06-10 14:31 ` [RFC PATCH 1/2] soc: qcom: do not disable the iface clock in probe Srinivas Kandagatla
2014-06-10 15:20   ` Kumar Gala
2014-06-10 17:39     ` Stephen Boyd
2014-06-10 17:46       ` Andy Gross
2014-06-10 17:47       ` Srinivas Kandagatla
2014-06-10 17:57         ` Andy Gross
2014-07-17 20:18   ` Srinivas Kandagatla
2014-08-12  4:25   ` Srinivas Kandagatla
2014-06-10 14:32 ` [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole Srinivas Kandagatla
2014-06-10 14:37   ` Srinivas Kandagatla
2014-06-17 21:09   ` Stephen Boyd
2014-06-17 22:04     ` Srinivas Kandagatla
2014-07-10 13:38     ` Srinivas Kandagatla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BE974E.6070804@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=agross@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.