From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752680AbaGJT7o (ORCPT ); Thu, 10 Jul 2014 15:59:44 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:51759 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbaGJT7m (ORCPT ); Thu, 10 Jul 2014 15:59:42 -0400 Message-ID: <53BEF0A8.7010608@kernel.dk> Date: Thu, 10 Jul 2014 21:59:36 +0200 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Jeff Moyer , Benjamin LaHaise CC: "Elliott\, Robert \(Server Storage\)" , Christoph Hellwig , "dgilbert@interlog.com" , James Bottomley , Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: scsi-mq V2 References: <1403715121-1201-1-git-send-email-hch@lst.de> <20140708144829.GA5539@infradead.org> <53BD7041.5010300@interlog.com> <53BD9A24.7010203@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B9628B@G9W0745.americas.hpqcorp.net> <20140710062040.GB20146@infradead.org> <20140710133609.GO12478@kvack.org> <20140710135051.GA28227@infradead.org> <53BE9AB1.6090603@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B96CF0@G9W0745.americas.hpqcorp.net> <20140710144539.GU12478@kvack.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-07-10 17:11, Jeff Moyer wrote: > Benjamin LaHaise writes: > >>> >>> [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339069] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> >> Something is horribly wrong here. There is no way that value for nr_events >> should be passed in to ioctx_alloc(). This implies that userland is calling >> io_setup() with an impossibly large value for nr_events. Can you post the >> actual diff for your fs/aio.c relative to linus' tree? >> > > fio does exactly this! it passes INT_MAX. That's correct, I had actually forgotten about this. It was a change made a few years back, in correlation with the aio optimizations posted then, basically telling aio to ignore that silly (and broken) user ring. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: scsi-mq V2 Date: Thu, 10 Jul 2014 21:59:36 +0200 Message-ID: <53BEF0A8.7010608@kernel.dk> References: <1403715121-1201-1-git-send-email-hch@lst.de> <20140708144829.GA5539@infradead.org> <53BD7041.5010300@interlog.com> <53BD9A24.7010203@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B9628B@G9W0745.americas.hpqcorp.net> <20140710062040.GB20146@infradead.org> <20140710133609.GO12478@kvack.org> <20140710135051.GA28227@infradead.org> <53BE9AB1.6090603@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B96CF0@G9W0745.americas.hpqcorp.net> <20140710144539.GU12478@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f49.google.com ([74.125.82.49]:51734 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbaGJT7l (ORCPT ); Thu, 10 Jul 2014 15:59:41 -0400 Received: by mail-wg0-f49.google.com with SMTP id a1so71529wgh.20 for ; Thu, 10 Jul 2014 12:59:38 -0700 (PDT) In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jeff Moyer , Benjamin LaHaise Cc: "Elliott, Robert (Server Storage)" , Christoph Hellwig , "dgilbert@interlog.com" , James Bottomley , Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" On 2014-07-10 17:11, Jeff Moyer wrote: > Benjamin LaHaise writes: > >>> >>> [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >>> [ 186.339069] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> >> Something is horribly wrong here. There is no way that value for nr_events >> should be passed in to ioctx_alloc(). This implies that userland is calling >> io_setup() with an impossibly large value for nr_events. Can you post the >> actual diff for your fs/aio.c relative to linus' tree? >> > > fio does exactly this! it passes INT_MAX. That's correct, I had actually forgotten about this. It was a change made a few years back, in correlation with the aio optimizations posted then, basically telling aio to ignore that silly (and broken) user ring. -- Jens Axboe