From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754610AbaGUKbN (ORCPT ); Mon, 21 Jul 2014 06:31:13 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35878 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392AbaGUKbL (ORCPT ); Mon, 21 Jul 2014 06:31:11 -0400 Message-ID: <53CCEBDA.1000504@gmail.com> Date: Mon, 21 Jul 2014 12:30:50 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kukjin Kim CC: Tomasz Figa , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Marek Szyprowski'" , Kukjin Kim , Kukjin Kim Subject: Re: [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality References: <1403618235-19353-1-git-send-email-t.figa@samsung.com> <1403618235-19353-5-git-send-email-t.figa@samsung.com> <033901cf9ab3$44c469a0$ce4d3ce0$@samsung.com> <53BBF7FF.6050105@samsung.com> <53C56CBF.1020500@samsung.com> <53C5C065.3010106@gmail.com> In-Reply-To: <53C5C065.3010106@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.07.2014 01:59, Tomasz Figa wrote: > On 15.07.2014 20:02, Kukjin Kim wrote: >> On 07/08/14 22:54, Tomasz Figa wrote: >>> On 08.07.2014 15:48, Kukjin Kim wrote: >>>> Tomasz Figa wrote: >>>>> >>>>> Due to recently merged patches and previous merge conflicts, the >>>>> Samsung >>>>> PM Debug functionality no longer can be enabled. This patch fixes >>>>> incorrect dependency of SAMSUNG_PM_DEBUG on an integer symbol and adds >>>>> missing header inclusion. >>>>> >>>> Yes, you're right and it should be fixed...but I have comments... >>>> >>>>> Signed-off-by: Tomasz Figa >>>>> --- >>>>> arch/arm/plat-samsung/Kconfig | 8 +++++++- >>>>> arch/arm/plat-samsung/pm-debug.c | 1 + >>>>> 2 files changed, 8 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm/plat-samsung/Kconfig >>>>> b/arch/arm/plat-samsung/Kconfig >>>>> index 301b892..483c959 100644 >>>>> --- a/arch/arm/plat-samsung/Kconfig >>>>> +++ b/arch/arm/plat-samsung/Kconfig >>>>> @@ -412,9 +412,14 @@ config S5P_DEV_MFC >>>>> >>>>> comment "Power management" >>>>> >>>>> +config HAVE_SAMSUNG_PM_DEBUG >>>>> + bool >>>>> + help >>>>> + Allow compilation of Samsung PM debugging code. >>>>> + >>>>> config SAMSUNG_PM_DEBUG >>>>> bool "S3C2410 PM Suspend debug" >>>>> - depends on PM&& DEBUG_KERNEL&& DEBUG_S3C_UART >>>>> + depends on PM&& DEBUG_KERNEL&& HAVE_SAMSUNG_PM_DEBUG >>>>> help >>>>> Say Y here if you want verbose debugging from the PM Suspend >>>>> and >>>>> Resume code. >>>>> See >>>>> @@ -484,6 +489,7 @@ config S5P_SLEEP >>>>> >>>>> config DEBUG_S3C_UART >>>>> depends on PLAT_SAMSUNG >>>>> + select HAVE_SAMSUNG_PM_DEBUG >>>> >>>> Hmm... >>>> >>>> The DEBUG_S3C_UART will be '0' when we select DEBUG_S3C_UART0, then the >>>> HAVE_SAMSUNG_PM_DEBUG will not be selected so SAMSUNG_PM_DEBUG is >>>> also... >>> >>> Yes, that's right. I posted v2 after a while in another reply to this >>> thread. >>> >> Any updates? Or I missed your updated? > > I'm afraid you missed. V2 has been there since a long time posted as a > reply to original patch. You can find it here: > > https://lkml.org/lkml/2014/6/25/301 Ping. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Mon, 21 Jul 2014 12:30:50 +0200 Subject: [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality In-Reply-To: <53C5C065.3010106@gmail.com> References: <1403618235-19353-1-git-send-email-t.figa@samsung.com> <1403618235-19353-5-git-send-email-t.figa@samsung.com> <033901cf9ab3$44c469a0$ce4d3ce0$@samsung.com> <53BBF7FF.6050105@samsung.com> <53C56CBF.1020500@samsung.com> <53C5C065.3010106@gmail.com> Message-ID: <53CCEBDA.1000504@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16.07.2014 01:59, Tomasz Figa wrote: > On 15.07.2014 20:02, Kukjin Kim wrote: >> On 07/08/14 22:54, Tomasz Figa wrote: >>> On 08.07.2014 15:48, Kukjin Kim wrote: >>>> Tomasz Figa wrote: >>>>> >>>>> Due to recently merged patches and previous merge conflicts, the >>>>> Samsung >>>>> PM Debug functionality no longer can be enabled. This patch fixes >>>>> incorrect dependency of SAMSUNG_PM_DEBUG on an integer symbol and adds >>>>> missing header inclusion. >>>>> >>>> Yes, you're right and it should be fixed...but I have comments... >>>> >>>>> Signed-off-by: Tomasz Figa >>>>> --- >>>>> arch/arm/plat-samsung/Kconfig | 8 +++++++- >>>>> arch/arm/plat-samsung/pm-debug.c | 1 + >>>>> 2 files changed, 8 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm/plat-samsung/Kconfig >>>>> b/arch/arm/plat-samsung/Kconfig >>>>> index 301b892..483c959 100644 >>>>> --- a/arch/arm/plat-samsung/Kconfig >>>>> +++ b/arch/arm/plat-samsung/Kconfig >>>>> @@ -412,9 +412,14 @@ config S5P_DEV_MFC >>>>> >>>>> comment "Power management" >>>>> >>>>> +config HAVE_SAMSUNG_PM_DEBUG >>>>> + bool >>>>> + help >>>>> + Allow compilation of Samsung PM debugging code. >>>>> + >>>>> config SAMSUNG_PM_DEBUG >>>>> bool "S3C2410 PM Suspend debug" >>>>> - depends on PM&& DEBUG_KERNEL&& DEBUG_S3C_UART >>>>> + depends on PM&& DEBUG_KERNEL&& HAVE_SAMSUNG_PM_DEBUG >>>>> help >>>>> Say Y here if you want verbose debugging from the PM Suspend >>>>> and >>>>> Resume code. >>>>> See >>>>> @@ -484,6 +489,7 @@ config S5P_SLEEP >>>>> >>>>> config DEBUG_S3C_UART >>>>> depends on PLAT_SAMSUNG >>>>> + select HAVE_SAMSUNG_PM_DEBUG >>>> >>>> Hmm... >>>> >>>> The DEBUG_S3C_UART will be '0' when we select DEBUG_S3C_UART0, then the >>>> HAVE_SAMSUNG_PM_DEBUG will not be selected so SAMSUNG_PM_DEBUG is >>>> also... >>> >>> Yes, that's right. I posted v2 after a while in another reply to this >>> thread. >>> >> Any updates? Or I missed your updated? > > I'm afraid you missed. V2 has been there since a long time posted as a > reply to original patch. You can find it here: > > https://lkml.org/lkml/2014/6/25/301 Ping. Best regards, Tomasz