Re: [oe-commits] Richard Tollerton : bootlogd: ensure /var/log/boot is created in volatiles

Re: [oe-commits] Richard Tollerton : bootlogd: ensure /var/log/boot is created in volatiles

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2949 bytes --]

On Mon, Jul 21, 2014 at 06:25:15PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master-next
> Commit: 6f963d761fa2916711b0d7808351515383bd5298
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
> 
> Author: Richard Tollerton <rich.tollerton@ni.com>
> Date:   Mon Jul 21 10:50:56 2014 -0500
> 
> bootlogd: ensure /var/log/boot is created in volatiles

subject usually starts with recipe/bbclass name, so it should be
sysvinit not bootlogd.

> bootlogd does not write to /var/log/boot if it does not exist,
> so if using the volatiles facility (presumed to mount /var/log under a
> tmpfs), ensure that /var/log/boot gets created.
> 
> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> Signed-off-by: Ben Shelton <ben.shelton@ni.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> ---
> 
>  meta/recipes-core/sysvinit/sysvinit/01_bootlogd | 1 +
>  meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb  | 7 ++++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/sysvinit/sysvinit/01_bootlogd b/meta/recipes-core/sysvinit/sysvinit/01_bootlogd
> new file mode 100644
> index 0000000..a689d92
> --- /dev/null
> +++ b/meta/recipes-core/sysvinit/sysvinit/01_bootlogd
> @@ -0,0 +1 @@
> +f root root 0644 /var/log/boot none
> diff --git a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> index 448d021..a8c10f2 100644
> --- a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> +++ b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> @@ -16,7 +16,9 @@ SRC_URI = "${SAVANNAH_GNU_MIRROR}/sysvinit/sysvinit-${PV}.tar.bz2 \
>             file://rcS-default \
>             file://rc \
>             file://rcS \
> -           file://bootlogd.init"
> +	   file://bootlogd.init \
> +           file://01_bootlogd \

Please don't mix tabs and spaces for indentation, only spaces should be used
in multi-line variables.

> +"
>  
>  SRC_URI[md5sum] = "6eda8a97b86e0a6f59dabbf25202aa6f"
>  SRC_URI[sha256sum] = "60bbc8c1e1792056e23761d22960b30bb13eccc2cabff8c7310a01f4d5df1519"
> @@ -92,6 +94,9 @@ do_install () {
>  	update-rc.d -r ${D} bootlogd start 07 S .
>  	update-rc.d -r ${D} stop-bootlogd start 99 2 3 4 5 .
>  
> +	install -d ${D}${sysconfdir}/default/volatiles
> +	install -m 0644 ${WORKDIR}/01_bootlogd ${D}${sysconfdir}/default/volatiles
> +
>  	chown root.shutdown ${D}${base_sbindir}/halt ${D}${base_sbindir}/shutdown
>  	chmod o-x,u+s ${D}${base_sbindir}/halt ${D}${base_sbindir}/shutdown
>  }
> 
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [oe-commits] Richard Tollerton : bootlogd: ensure /var/log/boot is created in volatiles

[Ben Shelton]

On 07/22, Martin Jansa wrote:
> On Mon, Jul 21, 2014 at 06:25:15PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master-next
> > Commit: 6f963d761fa2916711b0d7808351515383bd5298
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
> > 
> > Author: Richard Tollerton <rich.tollerton@ni.com>
> > Date:   Mon Jul 21 10:50:56 2014 -0500
> > 
> > bootlogd: ensure /var/log/boot is created in volatiles
> 
> subject usually starts with recipe/bbclass name, so it should be
> sysvinit not bootlogd.
> 
> 
> Please don't mix tabs and spaces for indentation, only spaces should be used
> in multi-line variables.
> 

Sorry about that -- do we need to resubmit the patch, or has it already
been merged?

Thanks,
Ben

> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [oe-commits] Richard Tollerton : bootlogd: ensure /var/log/boot is created in volatiles

[Saul Wold]

On 07/22/2014 08:30 AM, Ben Shelton wrote:
> On 07/22, Martin Jansa wrote:
>> On Mon, Jul 21, 2014 at 06:25:15PM +0000, git@git.openembedded.org wrote:
>>> Module: openembedded-core.git
>>> Branch: master-next
>>> Commit: 6f963d761fa2916711b0d7808351515383bd5298
>>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=6f963d761fa2916711b0d7808351515383bd5298
>>>
>>> Author: Richard Tollerton <rich.tollerton@ni.com>
>>> Date:   Mon Jul 21 10:50:56 2014 -0500
>>>
>>> bootlogd: ensure /var/log/boot is created in volatiles
>>
>> subject usually starts with recipe/bbclass name, so it should be
>> sysvinit not bootlogd.
>>
>>
>> Please don't mix tabs and spaces for indentation, only spaces should be used
>> in multi-line variables.
>>
>
> Sorry about that -- do we need to resubmit the patch, or has it already
> been merged?
>
It has not been merged yet, so please resubmit a v2 with fixed white space.

Sau!

> Thanks,
> Ben
>
>>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
>