From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9x6L-0000Mf-F8 for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:01:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9x6G-00059r-CF for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:01:01 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:47690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9x6G-00059Z-8b for qemu-devel@nongnu.org; Wed, 23 Jul 2014 10:00:56 -0400 Message-ID: <53CFC011.8020809@citrix.com> Date: Wed, 23 Jul 2014 16:00:49 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= MIME-Version: 1.0 References: <1400860669-21593-1-git-send-email-roger.pau@citrix.com> <1400860669-21593-3-git-send-email-roger.pau@citrix.com> <20140527132943.GD31463@stefanha-thinkpad.redhat.com> <53CE4F07.40804@citrix.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi On 22/07/14 14:26, Stefano Stabellini wrote: > On Tue, 22 Jul 2014, Roger Pau Monné wrote: >> On 27/05/14 15:29, Stefan Hajnoczi wrote: >>> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: >>>> The current behaviour of tap_open for BSD systems differ greatly from >>>> it's Linux counterpart. Since FreeBSD supports interface renaming and >>>> tap device cloning by opening /dev/tap, implement a FreeBSD specific >>>> version of tap_open that behaves like it's Linux counterpart. >>>> >>>> This is specially important for toolstacks that use Qemu (like Xen >>>> libxl), in order to have a unified behaviour across suported >>>> platforms. >>>> >>>> Signed-off-by: Roger Pau Monné >>>> Cc: xen-devel@lists.xenproject.org >>>> Cc: Stefano Stabellini >>>> Cc: Anthony Liguori >>>> Cc: Stefan Hajnoczi >>>> --- >>>> net/tap-bsd.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >>>> 1 files changed, 69 insertions(+), 1 deletions(-) >>> >>> Reviewed-by: Stefan Hajnoczi >> >> I still don't see this committed to the repository, should I ping someone? > > I was assuming that this patch would go via some other tree. But if > Stefan is OK I could pick it up and submit a pull request for both patch > 1 and 2 of this series. Would you do the backport of those three patches (one is already committed as e02bc6) to the qemu-xen repo at the same time, or would you like me to remind you about this in a month or so? I would really like to have all this patches in Xen 4.5 if possible. Thanks, Roger.