From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756208AbaGWOFc (ORCPT ); Wed, 23 Jul 2014 10:05:32 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49178 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754275AbaGWOFb (ORCPT ); Wed, 23 Jul 2014 10:05:31 -0400 Message-ID: <53CFC121.6040109@canonical.com> Date: Wed, 23 Jul 2014 16:05:21 +0200 From: Maarten Lankhorst User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Daniel Vetter CC: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Thomas Hellstrom , nouveau , LKML , dri-devel , Ben Skeggs , "Deucher, Alexander" Subject: Re: [Nouveau] [PATCH 09/17] drm/radeon: use common fence implementation for fences References: <20140709093124.11354.3774.stgit@patser> <53CF5EFE.6070307@canonical.com> <53CF63C2.7070407@vodafone.de> <53CF6622.6060803@amd.com> <53CF699D.9070902@canonical.com> <53CF6B18.5070107@vodafone.de> <53CF7035.2060808@amd.com> <53CF7191.2090008@canonical.com> <53CF765E.7020802@vodafone.de> <53CF8010.9060809@amd.com> <53CF822E.7050601@amd.com> <53CF84C7.2020507@vodafone.de> <53CF8693.1040006@canonical.com> <53CF8AB1.2000009@amd.com> <53CFAC38.9050501@amd.com> <53CFB5C2.7060207@canonical.com> In-Reply-To: <53CFB5C2.7060207@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org op 23-07-14 15:16, Maarten Lankhorst schreef: > op 23-07-14 14:36, Christian König schreef: >> Am 23.07.2014 12:52, schrieb Daniel Vetter: >>> On Wed, Jul 23, 2014 at 12:13 PM, Christian König >>> wrote: >>>>> And the dma-buf would still have fences belonging to both drivers, and it >>>>> would still call from outside the driver. >>>> Calling from outside the driver is fine as long as the driver can do >>>> everything necessary to complete it's work and isn't forced into any ugly >>>> hacks and things that are not 100% reliable. >>>> >>>> So I don't see much other approach as integrating recovery code for not >>>> firing interrupts and some kind of lockup handling into the fence code as >>>> well. >>> That approach doesn't really work at that well since every driver has >>> it's own reset semantics. And we're trying to move away from global >>> reset to fine-grained reset. So stop-the-world reset is out of >>> fashion, at least for i915. As you said, reset is normal in gpus and >>> we're trying to make reset less invasive. I really don't see a point >>> in imposing a reset scheme upon all drivers and I think you have about >>> as much motivation to convert radeon to the scheme used by i915 as >>> I'll have for converting to the one used by radeon. If it would fit at >>> all. >> Oh my! No, I didn't wanted to suggest any global reset infrastructure. >> >> My idea was more that the fence framework provides a fence->process_signaling callback that is periodically called after enable_signaling is called to trigger manual signal processing in the driver. >> >> This would both be suitable as a fallback in case of not working interrupts as well as a chance for any driver to do necessary lockup handling. > I managed to do it without needing it to be part of the interface? I'm not sure whether radeon_fence_driver_recheck needs exclusive_lock, but if so it's a small change.. > > diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h > index 7fbfd41479f1..51b646b9c8bb 100644 > --- a/drivers/gpu/drm/radeon/radeon.h > +++ b/drivers/gpu/drm/radeon/radeon.h > @@ -345,6 +345,9 @@ struct radeon_fence_driver { > uint64_t sync_seq[RADEON_NUM_RINGS]; > atomic64_t last_seq; > bool initialized; > + struct delayed_work work; > + struct radeon_device *rdev; > + unsigned ring; > }; > > struct radeon_fence_cb { > diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c > index da83f36dd708..955c825946ad 100644 > --- a/drivers/gpu/drm/radeon/radeon_fence.c > +++ b/drivers/gpu/drm/radeon/radeon_fence.c > @@ -231,6 +231,9 @@ static bool __radeon_fence_process(struct radeon_device *rdev, int ring) > } > } while (atomic64_xchg(&rdev->fence_drv[ring].last_seq, seq) > seq); > > + if (!wake && last_seq < last_emitted) > + schedule_delayed_work(&rdev->fence_drv[ring].work, jiffies_to_msecs(10)); > + > When trying this: if (seq < last_emitted) is probably a better check. ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences Date: Wed, 23 Jul 2014 16:05:21 +0200 Message-ID: <53CFC121.6040109@canonical.com> References: <20140709093124.11354.3774.stgit@patser> <53CF5EFE.6070307@canonical.com> <53CF63C2.7070407@vodafone.de> <53CF6622.6060803@amd.com> <53CF699D.9070902@canonical.com> <53CF6B18.5070107@vodafone.de> <53CF7035.2060808@amd.com> <53CF7191.2090008@canonical.com> <53CF765E.7020802@vodafone.de> <53CF8010.9060809@amd.com> <53CF822E.7050601@amd.com> <53CF84C7.2020507@vodafone.de> <5 3CF8693.1040006@canonical.com> <53CF8AB1.2000009@amd.com> <53CFAC38.9050501@amd.com> <53CFB5C2.7060207@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53CFB5C2.7060207-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Daniel Vetter Cc: Thomas Hellstrom , nouveau , LKML , dri-devel , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Ben Skeggs , "Deucher, Alexander" List-Id: nouveau.vger.kernel.org b3AgMjMtMDctMTQgMTU6MTYsIE1hYXJ0ZW4gTGFua2hvcnN0IHNjaHJlZWY6Cj4gb3AgMjMtMDct MTQgMTQ6MzYsIENocmlzdGlhbiBLw7ZuaWcgc2NocmVlZjoKPj4gQW0gMjMuMDcuMjAxNCAxMjo1 Miwgc2NocmllYiBEYW5pZWwgVmV0dGVyOgo+Pj4gT24gV2VkLCBKdWwgMjMsIDIwMTQgYXQgMTI6 MTMgUE0sIENocmlzdGlhbiBLw7ZuaWcKPj4+IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+IHdy b3RlOgo+Pj4+PiBBbmQgdGhlIGRtYS1idWYgd291bGQgc3RpbGwgaGF2ZSBmZW5jZXMgYmVsb25n aW5nIHRvIGJvdGggZHJpdmVycywgYW5kIGl0Cj4+Pj4+IHdvdWxkIHN0aWxsIGNhbGwgZnJvbSBv dXRzaWRlIHRoZSBkcml2ZXIuCj4+Pj4gQ2FsbGluZyBmcm9tIG91dHNpZGUgdGhlIGRyaXZlciBp cyBmaW5lIGFzIGxvbmcgYXMgdGhlIGRyaXZlciBjYW4gZG8KPj4+PiBldmVyeXRoaW5nIG5lY2Vz c2FyeSB0byBjb21wbGV0ZSBpdCdzIHdvcmsgYW5kIGlzbid0IGZvcmNlZCBpbnRvIGFueSB1Z2x5 Cj4+Pj4gaGFja3MgYW5kIHRoaW5ncyB0aGF0IGFyZSBub3QgMTAwJSByZWxpYWJsZS4KPj4+Pgo+ Pj4+IFNvIEkgZG9uJ3Qgc2VlIG11Y2ggb3RoZXIgYXBwcm9hY2ggYXMgaW50ZWdyYXRpbmcgcmVj b3ZlcnkgY29kZSBmb3Igbm90Cj4+Pj4gZmlyaW5nIGludGVycnVwdHMgYW5kIHNvbWUga2luZCBv ZiBsb2NrdXAgaGFuZGxpbmcgaW50byB0aGUgZmVuY2UgY29kZSBhcwo+Pj4+IHdlbGwuCj4+PiBU aGF0IGFwcHJvYWNoIGRvZXNuJ3QgcmVhbGx5IHdvcmsgYXQgdGhhdCB3ZWxsIHNpbmNlIGV2ZXJ5 IGRyaXZlciBoYXMKPj4+IGl0J3Mgb3duIHJlc2V0IHNlbWFudGljcy4gQW5kIHdlJ3JlIHRyeWlu ZyB0byBtb3ZlIGF3YXkgZnJvbSBnbG9iYWwKPj4+IHJlc2V0IHRvIGZpbmUtZ3JhaW5lZCByZXNl dC4gU28gc3RvcC10aGUtd29ybGQgcmVzZXQgaXMgb3V0IG9mCj4+PiBmYXNoaW9uLCBhdCBsZWFz dCBmb3IgaTkxNS4gQXMgeW91IHNhaWQsIHJlc2V0IGlzIG5vcm1hbCBpbiBncHVzIGFuZAo+Pj4g d2UncmUgdHJ5aW5nIHRvIG1ha2UgcmVzZXQgbGVzcyBpbnZhc2l2ZS4gSSByZWFsbHkgZG9uJ3Qg c2VlIGEgcG9pbnQKPj4+IGluIGltcG9zaW5nIGEgcmVzZXQgc2NoZW1lIHVwb24gYWxsIGRyaXZl cnMgYW5kIEkgdGhpbmsgeW91IGhhdmUgYWJvdXQKPj4+IGFzIG11Y2ggbW90aXZhdGlvbiB0byBj b252ZXJ0IHJhZGVvbiB0byB0aGUgc2NoZW1lIHVzZWQgYnkgaTkxNSBhcwo+Pj4gSSdsbCBoYXZl IGZvciBjb252ZXJ0aW5nIHRvIHRoZSBvbmUgdXNlZCBieSByYWRlb24uIElmIGl0IHdvdWxkIGZp dCBhdAo+Pj4gYWxsLgo+PiBPaCBteSEgTm8sIEkgZGlkbid0IHdhbnRlZCB0byBzdWdnZXN0IGFu eSBnbG9iYWwgcmVzZXQgaW5mcmFzdHJ1Y3R1cmUuCj4+Cj4+IE15IGlkZWEgd2FzIG1vcmUgdGhh dCB0aGUgZmVuY2UgZnJhbWV3b3JrIHByb3ZpZGVzIGEgZmVuY2UtPnByb2Nlc3Nfc2lnbmFsaW5n IGNhbGxiYWNrIHRoYXQgaXMgcGVyaW9kaWNhbGx5IGNhbGxlZCBhZnRlciBlbmFibGVfc2lnbmFs aW5nIGlzIGNhbGxlZCB0byB0cmlnZ2VyIG1hbnVhbCBzaWduYWwgcHJvY2Vzc2luZyBpbiB0aGUg ZHJpdmVyLgo+Pgo+PiBUaGlzIHdvdWxkIGJvdGggYmUgc3VpdGFibGUgYXMgYSBmYWxsYmFjayBp biBjYXNlIG9mIG5vdCB3b3JraW5nIGludGVycnVwdHMgYXMgd2VsbCBhcyBhIGNoYW5jZSBmb3Ig YW55IGRyaXZlciB0byBkbyBuZWNlc3NhcnkgbG9ja3VwIGhhbmRsaW5nLgo+IEkgbWFuYWdlZCB0 byBkbyBpdCB3aXRob3V0IG5lZWRpbmcgaXQgdG8gYmUgcGFydCBvZiB0aGUgaW50ZXJmYWNlPyBJ J20gbm90IHN1cmUgd2hldGhlciByYWRlb25fZmVuY2VfZHJpdmVyX3JlY2hlY2sgbmVlZHMgZXhj bHVzaXZlX2xvY2ssIGJ1dCBpZiBzbyBpdCdzIGEgc21hbGwgY2hhbmdlLi4KPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbi5oIGIvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9yYWRlb24uaAo+IGluZGV4IDdmYmZkNDE0NzlmMS4uNTFiNjQ2YjljOGJiIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3JhZGVvbi5oCj4gQEAgLTM0NSw2ICszNDUsOSBAQCBzdHJ1Y3QgcmFkZW9u X2ZlbmNlX2RyaXZlciB7Cj4gIAl1aW50NjRfdAkJCXN5bmNfc2VxW1JBREVPTl9OVU1fUklOR1Nd Owo+ICAJYXRvbWljNjRfdAkJCWxhc3Rfc2VxOwo+ICAJYm9vbAkJCQlpbml0aWFsaXplZDsKPiAr CXN0cnVjdCBkZWxheWVkX3dvcmsJCXdvcms7Cj4gKwlzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRl djsKPiArCXVuc2lnbmVkIHJpbmc7Cj4gIH07Cj4gIAo+ICBzdHJ1Y3QgcmFkZW9uX2ZlbmNlX2Ni IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZmVuY2UuYyBi L2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2ZlbmNlLmMKPiBpbmRleCBkYTgzZjM2ZGQ3 MDguLjk1NWM4MjU5NDZhZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Jh ZGVvbl9mZW5jZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZmVuY2Uu Ywo+IEBAIC0yMzEsNiArMjMxLDkgQEAgc3RhdGljIGJvb2wgX19yYWRlb25fZmVuY2VfcHJvY2Vz cyhzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldiwgaW50IHJpbmcpCj4gIAkJfQo+ICAJfSB3aGls ZSAoYXRvbWljNjRfeGNoZygmcmRldi0+ZmVuY2VfZHJ2W3JpbmddLmxhc3Rfc2VxLCBzZXEpID4g c2VxKTsKPiAgCj4gKwlpZiAoIXdha2UgJiYgbGFzdF9zZXEgPCBsYXN0X2VtaXR0ZWQpCj4gKwkJ c2NoZWR1bGVfZGVsYXllZF93b3JrKCZyZGV2LT5mZW5jZV9kcnZbcmluZ10ud29yaywgamlmZmll c190b19tc2VjcygxMCkpOwo+ICsKPgpXaGVuIHRyeWluZyB0aGlzOiBpZiAoc2VxIDwgbGFzdF9l bWl0dGVkKSBpcyBwcm9iYWJseSBhIGJldHRlciBjaGVjay4KCn5NYWFydGVuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlz dApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo=