From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH V2 03/12] Refactor get_parent_handle for sharing Date: Wed, 23 Jul 2014 17:37:19 +0100 Message-ID: <53D000DF0200007800025432@mail.emea.novell.com> References: <1405989815-25236-1-git-send-email-roy.franz@linaro.org> <1405989815-25236-4-git-send-email-roy.franz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405989815-25236-4-git-send-email-roy.franz@linaro.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roy Franz Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, linaro-uefi@lists.linaro.org, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org >>> On 22.07.14 at 02:43, wrote: > Refactor get_parent_handle() to return NULL on error rather than directly > exiting, as the exit cleanup code is arch specific. Is it? Not at this point at least. > Having the common code > reference the architecture specific code causes pre-linking to fail. Which certainly could be addressed if you told us details. > @@ -706,6 +720,9 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > /* Get the file system interface. */ > dir_handle = get_parent_handle(loaded_image, &file_name); > > + if ( !dir_handle ) Please avoid the rather pointless blank line above the if(). > + blexit(L"EFI get_parent_handle failed."); And please don't issue meaningless messages - the called function already prints messages on all failure paths. Jan