From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH V2 07/12] create handle_cmdline() function
Date: Thu, 24 Jul 2014 08:36:14 +0100
Message-ID: <53D0D38E020000780002560E@mail.emea.novell.com>
References: <1405989815-25236-1-git-send-email-roy.franz@linaro.org>
	<1405989815-25236-8-git-send-email-roy.franz@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1405989815-25236-8-git-send-email-roy.franz@linaro.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roy Franz <roy.franz@linaro.org>
Cc: keir@xen.org, ian.campbell@citrix.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, linaro-uefi@lists.linaro.org, fu.wei@linaro.org
List-Id: xen-devel@lists.xenproject.org

>>> On 22.07.14 at 02:43, <roy.franz@linaro.org> wrote:
> Create handle_cmdline() function in preparation for sharing to allow x86 and
> ARM architectures to share the command line processing.

I again can't see why the function doesn't get moved to the shared
file right away. And of course the splitting out again is questionable
considering that efi_start() itself ought to ultimately become a
shared function. By now I think you should have taken this the
other way round: Move the whole xen/arch/x86/efi/ subtree to
xen/common/efi/ and _then_ split out x86 specific code (possibly
into inline functions or #define-s rather than out of line code).

Jan