All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Juergen Gross <JGross@suse.com>, Keir Fraser <keir@xen.org>,
	ian.campbell@citrix.com, tim@xen.org,
	Dario Faggioli <dario.faggioli@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: domain_update_node_affinity: Correct the ASSERT
Date: Fri, 25 Jul 2014 16:42:08 +0100	[thread overview]
Message-ID: <53D296F002000078000261CD@mail.emea.novell.com> (raw)
In-Reply-To: <1406302204-13992-1-git-send-email-julien.grall@linaro.org>

>>> On 25.07.14 at 17:30, <julien.grall@linaro.org> wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -449,7 +449,7 @@ void domain_update_node_affinity(struct domain *d)
>          }
>          /* Filter out non-online cpus */
>          cpumask_and(dom_cpumask, dom_cpumask, online);
> -        ASSERT(!cpumask_empty(dom_cpumask));
> +        ASSERT( !d->vcpu || !d->vcpu[0] || !cpumask_empty(dom_cpumask));

Wouldn't it be better for the function to bail early in that case?

Jan

  reply	other threads:[~2014-07-25 15:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 15:30 [PATCH] xen: domain_update_node_affinity: Correct the ASSERT Julien Grall
2014-07-25 15:42 ` Jan Beulich [this message]
2014-07-25 15:44   ` Julien Grall
2014-07-25 15:59     ` Jan Beulich
2014-07-28 17:23       ` Dario Faggioli
2014-07-25 15:44 ` Andrew Cooper
2014-07-25 15:48   ` Julien Grall
2014-07-25 16:05     ` Andrew Cooper
2014-07-28 17:25 ` Dario Faggioli
2014-07-28 17:31   ` Julien Grall
2014-07-29  6:40     ` Jan Beulich
2014-07-29 10:46       ` Julien Grall
2014-08-01 14:52 Julien Grall
2014-08-01 15:12 ` Jan Beulich
2014-08-04 14:50   ` George Dunlap
2014-08-07 15:04     ` Julien Grall
2014-08-07 15:53       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D296F002000078000261CD@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.