From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAw1R-0003Ej-AS for qemu-devel@nongnu.org; Sat, 26 Jul 2014 03:04:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAw1I-0001wu-7q for qemu-devel@nongnu.org; Sat, 26 Jul 2014 03:04:01 -0400 Sender: Paolo Bonzini Message-ID: <53D352BD.2050004@redhat.com> Date: Sat, 26 Jul 2014 09:03:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1406303338-13212-1-git-send-email-imammedo@redhat.com> <53D28317.9090108@redhat.com> In-Reply-To: <53D28317.9090108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.1 0/2] Fix migration failure due to ACPI tables size changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , Igor Mammedov Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-stable@nongnu.org, dgilbert@redhat.com, mst@redhat.com Il 25/07/2014 18:17, Laszlo Ersek ha scritto: > In favor of your idea OTOH, as you explained, it would work for all > possible ACPI configurations, and not break for a random few ones like > Paolo's approach (talking about patch #2 of that set, the procedural > _PRT is great in any case). Note that, paradoxically, including the procedural _PRT will cause Igor's approach to fail, and the only way to fix it would be a similar hack. But actually Igor's patches make the dependency on the precise table size much smaller; for example a test like "if (version <= pc-i440fx-2.0) add 1500 bytes of padding to the tables" would work. Paolo