All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 06/10] sunxi: Add sun5i support
Date: Sat, 26 Jul 2014 15:11:08 +0200	[thread overview]
Message-ID: <53D3A8EC.3030601@redhat.com> (raw)
In-Reply-To: <20140723210256.53e28b50@i7>

Hi,

On 07/23/2014 08:02 PM, Siarhei Siamashka wrote:
> On Mon,  9 Jun 2014 11:36:58 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
>> Add support for the Allwinner A13 and A10s SoCs also know as the Allwinner
>> sun5i family, and the A13-OLinuXinoM A13 based and r7-tv-dongle A10s based
>> boards.
>>
>> The only differences compared to the already supported sun4i and sun7i
>> families are all in the DRAM controller initialization:
>>
>> -Different hcpr values
>> -Different MBUS settings
>> -Some other small initialization changes
>>
>> Signed-off-by: Henrik Nordstrom <henrik@henriknordstrom.net>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Signed-off-by: Oliver Schinagl <oliver@schinagl.nl>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>> ---
>>   arch/arm/cpu/armv7/sunxi/Makefile   |  2 ++
>>   arch/arm/cpu/armv7/sunxi/board.c    | 12 ++++++++++++
>>   arch/arm/cpu/armv7/sunxi/cpu_info.c |  8 ++++++++
>>   arch/arm/cpu/armv7/sunxi/dram.c     | 21 +++++++++++++++++++++
>>   board/sunxi/Makefile                |  2 ++
>>   board/sunxi/dram_a13_oli_micro.c    | 32 ++++++++++++++++++++++++++++++++
>>   board/sunxi/dram_r7dongle.c         | 31 +++++++++++++++++++++++++++++++
>>   boards.cfg                          |  2 ++
>>   include/configs/sun5i.h             | 23 +++++++++++++++++++++++
>>   include/configs/sunxi-common.h      |  2 ++
>>   10 files changed, 135 insertions(+)
>>   create mode 100644 board/sunxi/dram_a13_oli_micro.c
>>   create mode 100644 board/sunxi/dram_r7dongle.c
>>   create mode 100644 include/configs/sun5i.h
>
> Even if there is a valid reason to bundle the addition of some example
> sun5i based board to boards.cfg

To address this first, I believe that it is a good idea when adding
functionality to also enable it, otherwise one is just adding dead code.

> with the changes needed for sun5i SoC
> variant, why is it *two* boards this time?

Because there are 2 sun5i variants A13 and A10s

Regards,

Hans

  reply	other threads:[~2014-07-26 13:11 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09  9:36 [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements Hans de Goede
2014-06-09  9:36 ` [U-Boot] [PATCH v3 01/10] sunxi: mksunxiboot: Fix loading of files with a size which is not a multiple of 4 Hans de Goede
2014-06-09  9:36 ` [U-Boot] [PATCH v3 02/10] sunxi: Fix u-boot-spl.lds to refer to .vectors Hans de Goede
2014-06-09  9:36 ` [U-Boot] [PATCH v3 03/10] sunxi: Remove mmc DMA support Hans de Goede
2014-07-23 17:35   ` Siarhei Siamashka
2014-07-26 13:07     ` Hans de Goede
2014-06-09  9:36 ` [U-Boot] [PATCH v3 04/10] sunxi: Implement reset_cpu Hans de Goede
2014-07-23 17:45   ` Siarhei Siamashka
2014-07-26 13:09     ` Hans de Goede
2014-06-09  9:36 ` [U-Boot] [PATCH v3 05/10] sunxi: Add sun4i support Hans de Goede
2014-07-23 17:53   ` Siarhei Siamashka
2014-06-09  9:36 ` [U-Boot] [PATCH v3 06/10] sunxi: Add sun5i support Hans de Goede
2014-07-23 18:02   ` Siarhei Siamashka
2014-07-26 13:11     ` Hans de Goede [this message]
2014-06-09  9:36 ` [U-Boot] [PATCH v3 07/10] net: Rename and cleanup sunxi (Allwinner) emac driver Hans de Goede
2014-07-23 18:12   ` Siarhei Siamashka
2014-07-26 13:21     ` Hans de Goede
2014-07-26 13:31       ` Stefan Roese
2014-06-09  9:37 ` [U-Boot] [PATCH v3 08/10] sunxi: Add emac glue, enable emac on the cubieboard Hans de Goede
2014-07-23 18:18   ` Siarhei Siamashka
2014-06-09  9:37 ` [U-Boot] [PATCH v3 09/10] sunxi: Add support for using MII phy-s with the GMAC nic Hans de Goede
2014-07-23 18:20   ` Siarhei Siamashka
2014-06-09  9:37 ` [U-Boot] [PATCH v3 10/10] sunxi: Add Ian Campbell and Hans de Goede as cubietruck board-maintainers Hans de Goede
2014-06-25 19:57 ` [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements Ian Campbell
2014-06-26  7:38   ` Ian Campbell
2014-06-27  8:20     ` Stefan Roese
2014-07-06 19:12 ` Ian Campbell
2014-07-06 19:18   ` Albert ARIBAUD
2014-07-06 19:22     ` Ian Campbell
2014-07-06 20:54       ` Albert ARIBAUD
2014-07-06 21:28         ` Ian Campbell
2014-07-07  4:41           ` Wolfgang Denk
2014-07-07 12:50   ` Hans de Goede
2014-07-07 15:10     ` Ian Campbell
2014-07-07 16:47       ` Tom Rini
2014-07-07 20:23         ` Ian Campbell
2014-07-07 20:45           ` Tom Rini
2014-07-08  7:23             ` Ian Campbell
2014-07-08 13:48               ` Tom Rini
2014-07-08  7:48           ` Hans de Goede
2014-07-06 19:26 ` Ian Campbell
2014-07-07 12:53   ` Hans de Goede
2014-07-07 13:06     ` Tom Rini
2014-07-07 15:13     ` Ian Campbell
2014-07-08  7:47       ` Hans de Goede
2014-07-09  8:00         ` Ian Campbell
2014-07-09  8:44           ` Hans de Goede
2014-07-09 13:03           ` Henrik Nordström
2014-07-09 13:56             ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D3A8EC.3030601@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.