From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 28 Jul 2014 10:59:37 +0200
Subject: [U-Boot] [PATCH 4/7] sunxi: Add CONFIG_MACPWR option
In-Reply-To: <593AEF6C47F46446852B067021A273D6FB85A3D5@MUCSE037.lantiq.com>
References: <1406496323-13093-1-git-send-email-hdegoede@redhat.com>
	<1406496323-13093-4-git-send-email-hdegoede@redhat.com>
	<593AEF6C47F46446852B067021A273D6FB85A3D5@MUCSE037.lantiq.com>
Message-ID: <53D610F9.6050804@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 07/28/2014 10:09 AM, thomas.langer at lantiq.com wrote:
> Hello Hans,
> 
> Hans de Goede wrote on 2014-07-27:
>> On some boards the phy needs to be powered up through a gpio, add
>> support for this.
>>
> 
>> @@ -129,6 +129,11 @@ int cpu_eth_init(bd_t *bis)
>>  {
>>  	__maybe_unused int rc;
>> +#ifdef CONFIG_MACPWR
> 
> If this is powering a phy, maybe CONFIG_PHYPWR or similar is a better name?
> Because PHY and MAC are different things!

True, but there can be many kinds of PHYs usb phys, ahci phys,
ethernet phys, etc.

> And maybe adding GPIO to the name to indicate that the value is a GPIO number?

The current name mirrors the AHCIPWR setting we already for ahci
support on sinxi boards.

> All of these should be part of the description in the README,
> which each CONFIG_ option requires.

That is a good point. We've not documented any of the sunxi specific
options as of yet. Since we've quite a few I think it
might be better to add a new doc/README.sunxi file for this. I've
put creating such a file on my todo list.

Regards,

Hans