From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH V2 01/12] Create efi-shared.[ch], and move string functions Date: Mon, 28 Jul 2014 17:10:19 +0100 Message-ID: <53D6920B0200007800026CB0@mail.emea.novell.com> References: <1405989815-25236-1-git-send-email-roy.franz@linaro.org> <1405989815-25236-2-git-send-email-roy.franz@linaro.org> <53CFFF74020000780002540C@mail.emea.novell.com> <1406562064.17854.1.camel@kazak.uk.xensource.com> <53D68DD70200007800026C29@mail.emea.novell.com> <1406562976.17854.8.camel@kazak.uk.xensource.com> <53D68FBB0200007800026C45@mail.emea.novell.com> <1406563445.17854.14.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406563445.17854.14.camel@kazak.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: keir@xen.org, tim@xen.org, xen-devel@lists.xen.org, Roy Franz , stefano.stabellini@citrix.com, linaro-uefi@lists.linaro.org, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org >>> On 28.07.14 at 18:04, wrote: > On Mon, 2014-07-28 at 17:00 +0100, Jan Beulich wrote: >> >>> On 28.07.14 at 17:56, wrote: >> > On Mon, 2014-07-28 at 16:52 +0100, Jan Beulich wrote: >> >> > Even if not it looks like ~20K of mostly __init stuff, which doesn't >> >> > seem like the end of the world, especially given that more and more >> >> > toolstacks do support EFI with time. >> >> >> >> Right now - with the runtime code not moved over yet - it's >> >> mostly __init. Plus (with the linker not being able to discard that >> >> code) it carries the risk of having references to symbols that >> >> don't exist in the non-EFI build. >> > >> > Perhaps we can put the relevant code into efi specific sections and DTRT >> > in xen.lds.S? >> >> Maybe it could be made work, but I'd be wary of linker version issues >> then. > > Rather than arch .c files including common .c (or .inc) files how about > making xen/arch/*/efi/Makefile link xen/commmon/efi/built-in.o into it's > own built-in.o instead of having xen/common/Makefile do it like would > normally happen? That's an option. But I agree the inclusion of .c in another .c isn't really nice; I would therefore anyway favor a (set of) arch header file(s) providing everything the common code can't do on its own. Jan