From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
antonio@open-mesh.com
Subject: Re: [PATCH] ath9k: fix aggregation session lockup
Date: Mon, 28 Jul 2014 23:11:27 +0200 [thread overview]
Message-ID: <53D6BC7F.2020002@openwrt.org> (raw)
In-Reply-To: <53D6B87D.6080007@candelatech.com>
On 2014-07-28 22:54, Ben Greear wrote:
> On 07/23/2014 06:40 AM, Felix Fietkau wrote:
>> If an aggregation session fails, frames still end up in the driver queue
>> with IEEE80211_TX_CTL_AMPDU set.
>> This causes tx for the affected station/tid to stall, since
>> ath_tx_get_tid_subframe returning packets to send.
>>
>> Fix this by clearing IEEE80211_TX_CTL_AMPDU as long as no aggregation
>> session is running.
>
> Did this and your previous patch about 'pending tx frames accounting'
> fix the issues reported?
Yes.
> They at least do not fix the problems I see where tx appears to hang,
> but my setup is pretty 'special'....
Interesting. Maybe you should ask Antonio for an updated version of the
patch that he used to debug this issue. If you give me the output of it
while it's locked up, I might be able to figure out what's going on in
your setup.
- Felix
next prev parent reply other threads:[~2014-07-28 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 13:40 [PATCH] ath9k: fix aggregation session lockup Felix Fietkau
2014-07-28 20:54 ` Ben Greear
2014-07-28 21:11 ` Felix Fietkau [this message]
2014-07-28 21:17 ` Ben Greear
2014-07-29 16:05 ` Ben Greear
2014-08-04 13:27 ` Antonio Quartulli
2014-08-04 20:14 ` Ben Greear
2014-08-08 11:22 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D6BC7F.2020002@openwrt.org \
--to=nbd@openwrt.org \
--cc=antonio@open-mesh.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.