From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBsq0-00069B-Dt for qemu-devel@nongnu.org; Mon, 28 Jul 2014 17:52:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBspv-0005RM-F5 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 17:52:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBspv-0005RI-83 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 17:52:03 -0400 Message-ID: <53D6C600.7090502@redhat.com> Date: Mon, 28 Jul 2014 15:52:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com> <1406302776-2306-6-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1406302776-2306-6-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JONQeETM1CKpUpXIA8oiojWx4iv108LkB" Subject: Re: [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testing mechanism List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JONQeETM1CKpUpXIA8oiojWx4iv108LkB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > In this patch, I have made the following changes: >=20 > * changed the DPRINT statement. > * renamed the variables. > * added noqdev variable which decides which option to use for resetting= =2E > * added devices option which can help in resetting one or many devices > (only qdevified ones). > * updated the documentation. >=20 > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 26 ++++++ > qmp-commands.hx | 37 ++++++++ > savevm.c | 251 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 314 insertions(+) >=20 > +# > +# @noqdev: boolean variable which decides whether to use qdevified dev= ices > +# or not. Will be removed when all the devices have been qdevified. Please name this 'x-noqdev' if it is likely to be removed in the future, to make it obvious that it is not part of the permanent API. Also, mark it as optional, with a sane default, so that you can test the API without being forced to supply this temporary parameter. > +# > +# @devices: (optional) helps in resetting particular qdevified decices= > +# that have been registered with SaveStateEntry > +# > +# Since 2.2 > +## > +{ 'command': 'test-vmstates', > + 'data': {'*iterations': 'int', > + '*period': 'int', > + 'noqdev': 'bool', > + '*qdevices': 'VMStatesQdevDevices' } } Based on my comments on 3/12, if you rename that qapi to: { 'type': 'VMStatesQdevDevice', 'data': { 'device': 'str' } } then this should be '*qdevices': [ 'VMStatesQdevDevice' ] > + > +- "devices": (optional) helps in resetting particular qdevified decice= s s/decices/devices/ > + that have been registered with SaveStateEntry > + > + > +Example: > + > +-> { "execute": "test-vmstates", > + "arguments": { > + "iterations": 10, > + "period": 100, > + "noqdev": false } } If noqdev is going to disappear, I wouldn't include it in the example. Conversely, showing how to use 'devices' might be useful. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JONQeETM1CKpUpXIA8oiojWx4iv108LkB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT1sYAAAoJEKeha0olJ0Nq62QH/1X3f2z4Tr+UaOH23npeXYam KYNmTjeVHxsIJ3BJY94g/eCZVrZjqpJq3uDuXY00F3VxBwcd6OrxQsiC7HXrAbaX cb+tOFhoW8jzB2CDCx2S1yMWB4lCE4nssYuHudpo4E6SpXoVXHrBrpLSODr/Fafl WvePaYQb34aCXGMM+t7OUOJGl4T+EfX2yxBS0Nvq+kkktArROk8Q68hbY+3gGGev FJQNff24DUiEMkoD045MAjj4QxZ5jNpXdZnGsldCC+r76CTaKjtnEyzV/pP8ZiYE ZqvCCxEhNvZiZllpWv3S8JNgvn4U/E0AqScsNO2hKmfUETgw244txaS/SidKxso= =AtMR -----END PGP SIGNATURE----- --JONQeETM1CKpUpXIA8oiojWx4iv108LkB--