From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH 01/19] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Date: Tue, 29 Jul 2014 14:50:26 +0100 Message-ID: <53D7A6A2.9020005@arm.com> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-2-git-send-email-hanjun.guo@linaro.org> <53D69678.20002@arm.com> <53D79CD8.9050709@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:57482 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbaG2Nt7 convert rfc822-to-8bit (ORCPT ); Tue, 29 Jul 2014 09:49:59 -0400 In-Reply-To: <53D79CD8.9050709@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland Cc: Sudeep Holla , "graeme.gregory@linaro.org" , Arnd Bergmann , "grant.likely@linaro.org" , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On 29/07/14 14:08, Hanjun Guo wrote: > On 2014-7-29 2:29, Sudeep Holla wrote: > [...] >>> + >>> +/* >>> + * We never plan to use RSDT on arm/arm64 as its deprecated in spec but this >>> + * variable is still required by the ACPI core >>> + */ >>> +u32 acpi_rsdt_forced; >> >> This looks like yet another stray variable not used anywhere including >> core ACPI > > It will be used by ACPICA to get the RSDP in acpi_tb_parse_root_table() > in tbutils.c. > No I couldn't find it in mainline/acpica/linux-next(pm tree). On further digging found that commit fab461058385("ACPICA: Cleanup the option of forcing the use of the RSDT") has renamed it to acpi_gbl_do_not_use_xsdt and moved it into acpica with default false. So you can remove this. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753642AbaG2NuB (ORCPT ); Tue, 29 Jul 2014 09:50:01 -0400 Received: from service87.mimecast.com ([91.220.42.44]:57491 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbaG2Nt7 convert rfc822-to-8bit (ORCPT ); Tue, 29 Jul 2014 09:49:59 -0400 Message-ID: <53D7A6A2.9020005@arm.com> Date: Tue, 29 Jul 2014 14:50:26 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland CC: Sudeep Holla , "graeme.gregory@linaro.org" , Arnd Bergmann , "grant.likely@linaro.org" , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Al Stone , Tomasz Nowicki Subject: Re: [PATCH 01/19] ARM64 / ACPI: Get RSDP and ACPI boot-time tables References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-2-git-send-email-hanjun.guo@linaro.org> <53D69678.20002@arm.com> <53D79CD8.9050709@linaro.org> In-Reply-To: <53D79CD8.9050709@linaro.org> X-OriginalArrivalTime: 29 Jul 2014 13:49:53.0236 (UTC) FILETIME=[F95D5940:01CFAB33] X-MC-Unique: 114072914495514601 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/14 14:08, Hanjun Guo wrote: > On 2014-7-29 2:29, Sudeep Holla wrote: > [...] >>> + >>> +/* >>> + * We never plan to use RSDT on arm/arm64 as its deprecated in spec but this >>> + * variable is still required by the ACPI core >>> + */ >>> +u32 acpi_rsdt_forced; >> >> This looks like yet another stray variable not used anywhere including >> core ACPI > > It will be used by ACPICA to get the RSDP in acpi_tb_parse_root_table() > in tbutils.c. > No I couldn't find it in mainline/acpica/linux-next(pm tree). On further digging found that commit fab461058385("ACPICA: Cleanup the option of forcing the use of the RSDT") has renamed it to acpi_gbl_do_not_use_xsdt and moved it into acpica with default false. So you can remove this. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Tue, 29 Jul 2014 14:50:26 +0100 Subject: [PATCH 01/19] ARM64 / ACPI: Get RSDP and ACPI boot-time tables In-Reply-To: <53D79CD8.9050709@linaro.org> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-2-git-send-email-hanjun.guo@linaro.org> <53D69678.20002@arm.com> <53D79CD8.9050709@linaro.org> Message-ID: <53D7A6A2.9020005@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/07/14 14:08, Hanjun Guo wrote: > On 2014-7-29 2:29, Sudeep Holla wrote: > [...] >>> + >>> +/* >>> + * We never plan to use RSDT on arm/arm64 as its deprecated in spec but this >>> + * variable is still required by the ACPI core >>> + */ >>> +u32 acpi_rsdt_forced; >> >> This looks like yet another stray variable not used anywhere including >> core ACPI > > It will be used by ACPICA to get the RSDP in acpi_tb_parse_root_table() > in tbutils.c. > No I couldn't find it in mainline/acpica/linux-next(pm tree). On further digging found that commit fab461058385("ACPICA: Cleanup the option of forcing the use of the RSDT") has renamed it to acpi_gbl_do_not_use_xsdt and moved it into acpica with default false. So you can remove this. Regards, Sudeep