From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCA8H-0003eo-OH for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCA8B-0007Lk-V0 for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCA8B-0007KD-Mi for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:03 -0400 Message-ID: <53D7BA5D.40309@redhat.com> Date: Tue, 29 Jul 2014 09:14:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com> <1406302776-2306-4-git-send-email-sanidhya.iiith@gmail.com> <87ha20tjso.fsf@troll.troll> In-Reply-To: <87ha20tjso.fsf@troll.troll> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3c2WlGEGifdHK1mh0qq6ubILOVld6Iwps" Subject: Re: [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command to extract the qdevified device names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, Sanidhya Kashyap Cc: qemu list , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3c2WlGEGifdHK1mh0qq6ubILOVld6Iwps Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/29/2014 06:45 AM, Juan Quintela wrote: > Sanidhya Kashyap wrote: >> I have provided a qmp interface for getting the list of qdevified devi= ces >> that have been registered with SaveVMHandlers. >> >> Signed-off-by: Sanidhya Kashyap >> --- >> qapi-schema.json | 22 ++++++++++++++++++++++ >> qmp-commands.hx | 25 +++++++++++++++++++++++++ >> savevm.c | 34 ++++++++++++++++++++++++++++++++++ >> 3 files changed, 81 insertions(+) >> + >> +Example (1): >> + >> +-> { "execute": "query-qdev-devices" } >> +<- { "return": [ >> + { >> + "devices": [ "kvm-tpr-opt", "piix4_pm" ] >=20 > Once here, can we change this to also include the device version? >=20 > i.e. something like: >=20 > "devices": [ [ "device": [ "name": "kvm-tpr-opt", "version", 15]]], ..= =2E] Not valid JSON, but see my other messages in the thread. My idea of an array of structs would be nice for this: { "return": [ { "device": "kvm-tpr-opt", "version": 15 }, { "device": "piix4_pm", "version": 1 } ] } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3c2WlGEGifdHK1mh0qq6ubILOVld6Iwps Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT17pdAAoJEKeha0olJ0NqL/8H/3X3Mem721e4EZwO11QYDX5i 98xBh3Z8cEApqPjNEEq6eqJL9aeqdKBpe+Edajxm0vfDV14UHHFBfrp5PvRbhQzS wvZuiSXcy1URUg2z6NjRwZ9EQssmjlUu+Kr5Kvio/hUFjsslrl4R1Jd7/BLezNcs uhlHbbTzrYfmqZouC9xQsHYCeCWkVIHXnsEOVnQG5FVGg/MHoCVwqhYm6zB7T+eP i+2tfXjv0rZKo+Pgzn6aeWo3G4WEMAShpI7Bypb8S57r5QWXj02a8ALj2uzU/26Z iLoPwTCIMxnFXhAgT5XXwvA6JEBEIqsP5iOZLYCbw6fm1TWOmOov4GNt/2Rk4Js= =0tLy -----END PGP SIGNATURE----- --3c2WlGEGifdHK1mh0qq6ubILOVld6Iwps--