From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCAbd-0004BN-5r for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:50:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCAbX-00010l-B8 for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:50:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCAbX-00010d-2r for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:50:23 -0400 Message-ID: <53D7D0C7.9030407@redhat.com> Date: Tue, 29 Jul 2014 10:50:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com> <1406302776-2306-12-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1406302776-2306-12-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ilTEOMRMp2tDjmAJ8SNmpO2pKAWArVX41" Subject: Re: [Qemu-devel] [PATCH RFC v2 11/12] VMState test: cancel mechanism for an already running vmstate testing process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ilTEOMRMp2tDjmAJ8SNmpO2pKAWArVX41 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > Signed-off-by: Sanidhya Kashyap > --- > qapi-schema.json | 9 +++++++++ > qmp-commands.hx | 19 +++++++++++++++++++ > savevm.c | 16 ++++++++++++++-- > 3 files changed, 42 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 13e922e..91f1672 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3574,3 +3574,12 @@ > ## > { 'command' : 'test-vmstates-set-period', > 'data' : { 'period': 'int' } } > + > +## > +# @log-dirty-bitmap-cancel > +# > +# cancel the testing vmstates process > +# > +# Since 2.2 > +## > +{ 'command': 'test-vmstates-cancel' } Command name doesn't match documentation. > + > +SQMP > +test-vmstates-cancel > +-------------- Make the ---- line up to the command name. > +++ b/savevm.c > @@ -1365,8 +1365,12 @@ static void vmstate_test_cb(void *opaque) > if (saved_vm_running) { > vm_start(); > } > - timer_mod(v->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + > - v->period); > + if (v->active_state) { Indentation is off. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ilTEOMRMp2tDjmAJ8SNmpO2pKAWArVX41 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT19DHAAoJEKeha0olJ0Nq8aMH/iK1PbvBLauKKJi2ZToeshVQ a1qFkgIIXkHaJWaCo/DB+3i1MHKKzMkVB3osm6q/sMviJcpZ2qo9LknVgKhtGRvF 5m4nkDef6XyJM3fslurIRodPjWwG5Q4xzH3v0rRep/hzhk+DY+o0cB4P1YKiDhZw F7AaZxiQUb71nDWRXh+EP3pzZglHfceN0RVv3nBw3gll+1bZ27M4LGpndlJRQcww nS73LCnokBQFBMMR8BGGMsdD/mcUFha4SHJPwesv12pgKkSe/po6ky3mXGcgUveL wDSAq2WZoNpgZeKYWk71OrA3Yuh/seD+HeGuTfaUYlUhJf+okqRibjjrz2Vztqo= =rGQE -----END PGP SIGNATURE----- --ilTEOMRMp2tDjmAJ8SNmpO2pKAWArVX41--