From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanidhya.iiith@gmail.com>) id 1XCBLC-0004by-Bs
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 13:37:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sanidhya.iiith@gmail.com>) id 1XCBL3-00088k-Ax
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 13:37:34 -0400
Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:39520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sanidhya.iiith@gmail.com>) id 1XCBL3-00088S-3d
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 13:37:25 -0400
Received: by mail-pa0-f42.google.com with SMTP id lf10so12823673pab.1
	for <qemu-devel@nongnu.org>; Tue, 29 Jul 2014 10:37:23 -0700 (PDT)
Message-ID: <53D7DBC0.2030407@gmail.com>
Date: Tue, 29 Jul 2014 23:07:04 +0530
From: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
MIME-Version: 1.0
References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com>	<1406302776-2306-4-git-send-email-sanidhya.iiith@gmail.com>
	<87ha20tjso.fsf@troll.troll>
In-Reply-To: <87ha20tjso.fsf@troll.troll>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command
 to extract the qdevified device names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu list <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>



>> +##
>> +# @VMstatesQdevDevices
>> +#
>> +# list of qdevified devices that are registered with SaveStateEntry
>> +#
>> +# @device: list of qdevified device names
> 
> 
> Should we use qdev on the name?  Or just list of devices?  My
> understanding is that all devices are on this list, no?
> 

The problem is that there are some devices which have not been
qdevified. So, that's why I used the term qdev. If you want, I can
remove the term qdev. Sooner or later all the devices will be qdevified.

>> +
>> +-> { "execute": "query-qdev-devices" }
>> +<- { "return": [
>> +       {
>> +         "devices": [ "kvm-tpr-opt", "piix4_pm" ]
> 
> Once here, can we change this to also include the device version?
> 
> i.e. something like:
> 
>  "devices": [ [ "device": [ "name": "kvm-tpr-opt", "version", 15]]], ...]
> 
> Or somesuch?
> 

That is possible. Do you want any other information to be printed?

-- 
-----

Sanidhya Kashyap