From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCDId-00012A-67 for qemu-devel@nongnu.org; Tue, 29 Jul 2014 15:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCDIY-0000wr-67 for qemu-devel@nongnu.org; Tue, 29 Jul 2014 15:43:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCDIX-0000wf-Tu for qemu-devel@nongnu.org; Tue, 29 Jul 2014 15:42:58 -0400 Message-ID: <53D7F93B.9000409@redhat.com> Date: Tue, 29 Jul 2014 13:42:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com> <1406302776-2306-10-git-send-email-sanidhya.iiith@gmail.com> <53D7D074.3070006@redhat.com> <53D7E246.2040303@gmail.com> In-Reply-To: <53D7E246.2040303@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wExRbEr5mb0WSBoT7WlU2JMQULX8CdU6M" Subject: Re: [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wExRbEr5mb0WSBoT7WlU2JMQULX8CdU6M Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/29/2014 12:04 PM, Sanidhya Kashyap wrote: >>> +void qmp_test_vmstates_set_period(int64_t period, Error **errp)=20 >>> +{ + VMStateLogState *v =3D vmstate_current_state(); + if >>> (period < TEST_VMSTATE_MIN_INTERVAL_MS || + period > >>> TEST_VMSTATE_MAX_INTERVAL_MS) { + error_setg(errp, "sleep >>> interval (period) value must be " + "in the >>> defined range [%d, %d](ms)\n", + >>> TEST_VMSTATE_MIN_INTERVAL_MS, TEST_VMSTATE_MAX_INTERVAL_MS); + >>> return; + } + v->period =3D period; +} Uggh, your mailer clobbered whitespace when replying :( >=20 >> This looks like it takes effect whether or not a vmstate test is=20 >> underway. Does this impact the default of the next vmstate test >> to >=20 > Yes >=20 >> start, in the case where that command doesn't supply a value for >> period but relies on the default? >=20 > No, it does not. Then it may be worth fixing the command to error out if there is no active vmstate test underway, instead of changing a value that has no effect. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wExRbEr5mb0WSBoT7WlU2JMQULX8CdU6M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT1/k7AAoJEKeha0olJ0Nq0GgH/A/xHOGkfXqNoQZ9ZL++fL2m JXOysI4IVYE9d9vGrcG40JNaGs9bs+hsQ4AVxjLgAnM4oA2JcaDyx08S+r2K4MKn qZBpjTacMRoRXecaCXnKJ44MQHQVbwGgHVEviSVnxFrG1N3Ssvmsyrvm9wqg3JKe pjE8M0nuIWMAc3LJGdua+DU4o8+1FwV96oEVC2SpWltlEvHSVZNYYj22kCbZND0M 9aZ6MtArQATvgVzoH9ZYXivLa9oJGXRcdj0oHKlFsMR56UjOcQB+daqeEWSq4Dpu 1qY7Sa+duYrsrjCWadJt6ADkSJndE6j8+dWNN6FQDXxiYpSj14kmi+rXFBfvR9s= =0cbR -----END PGP SIGNATURE----- --wExRbEr5mb0WSBoT7WlU2JMQULX8CdU6M--