From: Don Dutile <ddutile@redhat.com>
To: Edward Cree <ecree@solarflare.com>, linux-pci@vger.kernel.org
Subject: Re: pci_sriov_set_totalvfs again
Date: Wed, 30 Jul 2014 14:05:59 -0400 [thread overview]
Message-ID: <53D93407.8040308@redhat.com> (raw)
In-Reply-To: <53D9288B.5030302@solarflare.com>
On 07/30/2014 01:16 PM, Edward Cree wrote:
> Calling pci_sriov_set_totalvfs(dev, 0) has no effect, because pci_sriov_get_totalvfs ignores dev->sriov->driver_max_VFs if it's 0, as that is used as the 'not set' value.
> So, three questions:
> a) is this a bug?
> b) if not, should the comment on pci_sriov_set_totalvfs mention that passing numvfs=0 will be interpreted as numvfs=dev->sriov->total_VFs?
> c) is there a better way of indicating "current configuration doesn't support VFs" rather than calling set_totalvfs(0)?
>
> Thanks,
> -Edward
> ||The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.
The file shouldn't exist if the device doesn't provide an SRIOV capability.
If it does, and it's not supported, then add a patch in quirks.c.
next parent reply other threads:[~2014-07-30 18:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53D9288B.5030302@solarflare.com>
2014-07-30 18:05 ` Don Dutile [this message]
2014-07-30 18:24 ` pci_sriov_set_totalvfs again Edward Cree
2014-07-30 21:14 ` Alexander Duyck
2014-07-31 12:07 ` Edward Cree
2014-07-31 14:24 ` [PATCH] PCI: handle pci_sriov_set_totalvfs(dev, 0) Edward Cree
2014-07-31 15:21 ` Alexander Duyck
2014-07-31 15:56 ` Edward Cree
2014-07-31 16:40 ` Alexander Duyck
2014-07-31 16:57 ` Edward Cree
2014-07-31 17:53 ` Don Dutile
2014-07-31 18:13 ` Edward Cree
2014-08-04 14:03 ` Edward Cree
2014-08-04 14:37 ` Alexander Duyck
2014-08-04 15:22 ` Edward Cree
2014-08-06 9:38 ` Don Dutile
2014-07-31 17:55 ` Alexander Duyck
2014-07-31 18:24 ` Edward Cree
2014-08-01 3:18 ` Ethan Zhao
2014-08-01 11:51 ` Edward Cree
2014-08-02 0:34 ` Ethan Zhao
2014-08-01 3:51 ` Ethan Zhao
2014-08-01 12:15 ` Edward Cree
2014-08-02 0:25 ` Ethan Zhao
2014-08-04 15:45 ` Edward Cree
2014-08-04 16:40 ` Alexander Duyck
2014-08-04 17:08 ` Edward Cree
2014-08-04 6:53 ` Sathya Perla
2014-07-30 17:23 pci_sriov_set_totalvfs again Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D93407.8040308@redhat.com \
--to=ddutile@redhat.com \
--cc=ecree@solarflare.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.