From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v02 1/7] arm: introduce remoteprocessor
 iommu module
Date: Fri, 01 Aug 2014 11:32:19 +0100
Message-ID: <53DB6CB3.8010303@linaro.org>
References: <1403780826-22123-1-git-send-email-andrii.tseglytskyi@globallogic.com>	<1403780826-22123-2-git-send-email-andrii.tseglytskyi@globallogic.com>	<alpine.DEB.2.02.1407041436130.27641@kaball.uk.xensource.com>	<CAH_mUMOZ5K8tn1p=dLizdEsurHczsjQe33UU2gN9wvMvbm051w@mail.gmail.com>
	<CAH_mUMPAQKdCZaqfGR4mKqcoFxvoyUQ0__LPdoQw8GC2Fo=ZZA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAH_mUMPAQKdCZaqfGR4mKqcoFxvoyUQ0__LPdoQw8GC2Fo=ZZA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


Hi Andrii,

On 01/08/14 11:06, Andrii Tseglytskyi wrote:
>>>> +static int mmu_mmio_write(struct vcpu *v, mmio_info_t *info)
>>>> +{
>>>> +    struct mmu_info *mmu = NULL;
>>>> +    unsigned long flags;
>>>> +    register_t *r;
>>>> +    u32 new_addr, val;
>>>> +
>>>> +    r = select_user_reg(guest_cpu_user_regs(), info->dabt.reg);
>>>> +
>>>> +    ASSERT(r);
>>>> +
>>>> +    /* dom0 should not access remoteproc MMU */
>>>> +    if ( 0 == current->domain->domain_id )
>>>> +        return 1;
>>>
>>> This is too specific to one particular configuration.
>>> Would it be possible to generalize this somehow? At the very least you
>>> could introduce an XSM label to access the pagetables, so that you can
>>> dynamically configure the domains the can write to them.
>>>
>>
>> I need to think about this. Sounds reasonable.
>>
>
> I tried to compile Xen with XSM support and got an error with
> including msi.h file:
>
> arm-linux-gnueabi-gcc -O1 -fno-omit-frame-pointer -marm -g
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
> -Wdeclaration-after-statement -Wno-unused-but-set-variable
> -I/home/x0174653/xen/dra7/core_dra7/hypervisor/xen/include -nopie
> -fno-stack-protector -fno-exceptions -Wnested-externs -msoft-float
> -mcpu=cortex-a15 -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
> -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g
> -D__XEN__ -include
> /home/x0174653/xen/dra7/core_dra7/hypervisor/xen/include/xen/config.h
> -nostdinc -fno-optimize-sibling-calls -DXSM_ENABLE -DFLASK_ENABLE
> -DXSM_MAGIC=0xf97cff8c -DFLASK_DEVELOP -DFLASK_BOOTPARAM
> -DFLASK_AVC_STATS -DVERBOSE -DHAS_DEVICE_TREE -fno-omit-frame-pointer
> -DCONFIG_FRAME_POINTER -MMD -MF .hooks.o.d -I./include -c hooks.c -o
> hooks.o
> hooks.c:22:21: fatal error: asm/msi.h: No such file or directory
>
> I see that msi.h is available only for x86 platforms. So, the question
> is - is XSM supported on ARMs ?

It's supported only on Xen unstable since last march. On which branch 
are you working on?

Regards,

-- 
Julien Grall